From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751231Ab3IIAxJ (ORCPT ); Sun, 8 Sep 2013 20:53:09 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:47560 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750848Ab3IIAxH (ORCPT ); Sun, 8 Sep 2013 20:53:07 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v2.0.1 X-SHieldMailCheckerPolicyVersion: FJ-ISEC-20120718-3 Message-ID: <522D1BC4.9080500@jp.fujitsu.com> Date: Mon, 9 Sep 2013 09:52:20 +0900 From: Yasuaki Ishimatsu User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Xishi Qiu CC: Andrew Morton , Wen Congyang , Tang Chen , Toshi Kani , , LKML Subject: Re: [PATCH] mm/hotplug: rename the function is_memblock_offlined_cb() References: <52299848.1000105@huawei.com> In-Reply-To: <52299848.1000105@huawei.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SecurityPolicyCheck-GC: OK by FENCE-Mail Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2013/09/06 17:54), Xishi Qiu wrote: > Function is_memblock_offlined() return 1 means memory block is offlined, > but is_memblock_offlined_cb() return 1 means memory block is not offlined, > this will confuse somebody, so rename the function. > Another, use "pfn_to_nid(pfn)" instead of "page_to_nid(pfn_to_page(pfn))". > > Signed-off-by: Xishi Qiu > --- It looks good to me. But I have one comment. Please see below. > mm/memory_hotplug.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index ca1dd3a..a95dd28 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -937,7 +937,7 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ > arg.nr_pages = nr_pages; > node_states_check_changes_online(nr_pages, zone, &arg); > > - nid = page_to_nid(pfn_to_page(pfn)); > + nid = pfn_to_nid(pfn); Please split the cleanup from this patch since the cleanup has nothing to do with the description of this patch. Thanks, Yasuaki Ishimatsu > > ret = memory_notify(MEM_GOING_ONLINE, &arg); > ret = notifier_to_errno(ret); > @@ -1657,7 +1657,7 @@ int walk_memory_range(unsigned long start_pfn, unsigned long end_pfn, > } > > #ifdef CONFIG_MEMORY_HOTREMOVE > -static int is_memblock_offlined_cb(struct memory_block *mem, void *arg) > +static int check_memblock_offlined_cb(struct memory_block *mem, void *arg) > { > int ret = !is_memblock_offlined(mem); > > @@ -1794,7 +1794,7 @@ void __ref remove_memory(int nid, u64 start, u64 size) > * if this is not the case. > */ > ret = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL, > - is_memblock_offlined_cb); > + check_memblock_offlined_cb); > if (ret) { > unlock_memory_hotplug(); > BUG(); >