From: Larry Finger <Larry.Finger@lwfinger.net>
To: farisdehaan@gmail.com
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8188eu: checkpatch.pl warnings removed
Date: Mon, 09 Sep 2013 11:10:18 -0500 [thread overview]
Message-ID: <522DF2EA.2090106@lwfinger.net> (raw)
In-Reply-To: <522dea9f.47250e0a.0f3f.ffffc2dc@mx.google.com>
On 09/09/2013 10:34 AM, farisdehaan@gmail.com wrote:
> From: Faris de Haan <farisdehaan@gmail.com>
>
> Fixed some of the coding style issues reported by checkpatch.pl
>
> Signed-off-by: Faris de Haan <farisdehaan@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> index c2977be..cd3c9a7 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> @@ -267,9 +267,8 @@ _func_enter_;
>
> rtw_mfree_sta_priv_lock(pstapriv);
>
> - if (pstapriv->pallocated_stainfo_buf) {
> + if (pstapriv->pallocated_stainfo_buf)
> rtw_vmfree(pstapriv->pallocated_stainfo_buf, sizeof(struct sta_info)*NUM_STA+4);
> - }
> }
>
> _func_exit_;
> @@ -315,7 +314,7 @@ _func_enter_;
>
> rtw_list_insert_tail(&psta->hash_list, phash_list);
>
> - pstapriv->asoc_sta_count++ ;
> + pstapriv->asoc_sta_count++;
>
> _exit_critical_bh(&(pstapriv->sta_hash_lock), &irql2);
>
> @@ -419,7 +418,7 @@ _func_enter_;
> _cancel_timer_ex(&psta->addba_retry_timer);
>
> /* for A-MPDU Rx reordering buffer control, cancel reordering_ctrl_timer */
> - for (i = 0; i < 16 ; i++) {
> + for (i = 0; i < 16; i++) {
> unsigned long irql;
> struct list_head *phead, *plist;
> union recv_frame *prframe;
>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
prev parent reply other threads:[~2013-09-09 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 15:34 [PATCH] Staging: rtl8188eu: checkpatch.pl warnings removed farisdehaan
2013-09-09 16:10 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522DF2EA.2090106@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=farisdehaan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox