public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: rtl8188eu: checkpatch.pl warnings removed
@ 2013-09-09 15:34 farisdehaan
  2013-09-09 16:10 ` Larry Finger
  0 siblings, 1 reply; 2+ messages in thread
From: farisdehaan @ 2013-09-09 15:34 UTC (permalink / raw)
  To: gregkh; +Cc: larry.finger, devel, linux-kernel, Faris de Haan

From: Faris de Haan <farisdehaan@gmail.com>

Fixed some of the coding style issues reported by checkpatch.pl

Signed-off-by: Faris de Haan <farisdehaan@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_sta_mgt.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
index c2977be..cd3c9a7 100644
--- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
+++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
@@ -267,9 +267,8 @@ _func_enter_;
 
 		rtw_mfree_sta_priv_lock(pstapriv);
 
-		if (pstapriv->pallocated_stainfo_buf) {
+		if (pstapriv->pallocated_stainfo_buf)
 			rtw_vmfree(pstapriv->pallocated_stainfo_buf, sizeof(struct sta_info)*NUM_STA+4);
-		}
 	}
 
 _func_exit_;
@@ -315,7 +314,7 @@ _func_enter_;
 
 		rtw_list_insert_tail(&psta->hash_list, phash_list);
 
-		pstapriv->asoc_sta_count++ ;
+		pstapriv->asoc_sta_count++;
 
 		_exit_critical_bh(&(pstapriv->sta_hash_lock), &irql2);
 
@@ -419,7 +418,7 @@ _func_enter_;
 	_cancel_timer_ex(&psta->addba_retry_timer);
 
 	/* for A-MPDU Rx reordering buffer control, cancel reordering_ctrl_timer */
-	for (i = 0; i < 16 ; i++) {
+	for (i = 0; i < 16; i++) {
 		unsigned long irql;
 		struct list_head *phead, *plist;
 		union recv_frame *prframe;
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Staging: rtl8188eu: checkpatch.pl warnings removed
  2013-09-09 15:34 [PATCH] Staging: rtl8188eu: checkpatch.pl warnings removed farisdehaan
@ 2013-09-09 16:10 ` Larry Finger
  0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2013-09-09 16:10 UTC (permalink / raw)
  To: farisdehaan; +Cc: gregkh, devel, linux-kernel

On 09/09/2013 10:34 AM, farisdehaan@gmail.com wrote:
> From: Faris de Haan <farisdehaan@gmail.com>
>
> Fixed some of the coding style issues reported by checkpatch.pl
>
> Signed-off-by: Faris de Haan <farisdehaan@gmail.com>
> ---
>   drivers/staging/rtl8188eu/core/rtw_sta_mgt.c |    7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> index c2977be..cd3c9a7 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> @@ -267,9 +267,8 @@ _func_enter_;
>
>   		rtw_mfree_sta_priv_lock(pstapriv);
>
> -		if (pstapriv->pallocated_stainfo_buf) {
> +		if (pstapriv->pallocated_stainfo_buf)
>   			rtw_vmfree(pstapriv->pallocated_stainfo_buf, sizeof(struct sta_info)*NUM_STA+4);
> -		}
>   	}
>
>   _func_exit_;
> @@ -315,7 +314,7 @@ _func_enter_;
>
>   		rtw_list_insert_tail(&psta->hash_list, phash_list);
>
> -		pstapriv->asoc_sta_count++ ;
> +		pstapriv->asoc_sta_count++;
>
>   		_exit_critical_bh(&(pstapriv->sta_hash_lock), &irql2);
>
> @@ -419,7 +418,7 @@ _func_enter_;
>   	_cancel_timer_ex(&psta->addba_retry_timer);
>
>   	/* for A-MPDU Rx reordering buffer control, cancel reordering_ctrl_timer */
> -	for (i = 0; i < 16 ; i++) {
> +	for (i = 0; i < 16; i++) {
>   		unsigned long irql;
>   		struct list_head *phead, *plist;
>   		union recv_frame *prframe;
>

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

Thanks,

Larry


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-09 16:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-09 15:34 [PATCH] Staging: rtl8188eu: checkpatch.pl warnings removed farisdehaan
2013-09-09 16:10 ` Larry Finger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox