From: Stephen Warren <swarren@wwwdotorg.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wei Ni <wni@nvidia.com>,
khali@linux-fr.org, broonie@kernel.org,
lm-sensors@lm-sensors.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] Documentation: dt: hwmon: add OF document for LM90
Date: Mon, 09 Sep 2013 16:14:44 -0600 [thread overview]
Message-ID: <522E4854.1050800@wwwdotorg.org> (raw)
In-Reply-To: <522DA86B.6000603@roeck-us.net>
On 09/09/2013 04:52 AM, Guenter Roeck wrote:
> On 09/09/2013 03:29 AM, Wei Ni wrote:
>> Add OF document for LM90 in Documentation/devicetree/.
>> diff --git a/Documentation/devicetree/bindings/hwmon/lm90.txt
>> +* LM90 series thermometer.
>> +
>> +Required node properties:
>> +- compatible: manufacture and chip name, one of
>
> manufacturer
>
>> + "<manufacture>,adm1032"
...
>> + "<manufacture>,sa56004"
>
> Shouldn't the manufacturers be listed explicitly ?
Yes, and they must all be present in
Documentation/devicetree/bindings/vendor-prefixes.txt.
>> +Example LM90 node:
>> +
>> +temp-sensor {
>> + compatible = "onnn,nct1008";
>> + reg = <0x4c>;
>> + vcc-supply = <&palmas_ldo6_reg>;
>> + interrupt-parent = <&gpio>;
>
> List above as optional property.
I believe it's common not to document this, since it's implicitly
supported as part of any node that is an interrupt source.
next prev parent reply other threads:[~2013-09-09 22:14 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 10:29 [PATCH v3 0/2] Add power control for lm90 Wei Ni
2013-09-09 10:29 ` [PATCH v3 1/2] hwmon: (lm90) Add power control Wei Ni
2013-09-09 11:12 ` Mark Brown
2013-09-09 11:34 ` Guenter Roeck
2013-09-09 13:50 ` Mark Brown
2013-09-09 15:50 ` Guenter Roeck
2013-09-09 16:02 ` Mark Brown
2013-09-09 16:17 ` Guenter Roeck
2013-09-09 20:39 ` Mark Brown
2013-09-10 4:05 ` Wei Ni
2013-09-10 4:50 ` Guenter Roeck
2013-09-10 5:39 ` Wei Ni
2013-09-10 5:54 ` Guenter Roeck
2013-09-10 6:30 ` Wei Ni
2013-09-10 10:13 ` Mark Brown
2013-09-10 11:29 ` Wei Ni
2013-09-10 12:11 ` Mark Brown
2013-09-11 9:40 ` Wei Ni
2013-09-10 3:22 ` Wei Ni
2013-09-10 3:36 ` Guenter Roeck
2013-09-10 3:40 ` Stephen Warren
2013-09-10 3:53 ` Guenter Roeck
2013-09-10 4:12 ` Wei Ni
2013-09-10 4:13 ` Stephen Warren
2013-09-10 4:44 ` Guenter Roeck
2013-09-10 10:09 ` Mark Brown
2013-09-10 15:07 ` Stephen Warren
2013-09-10 17:04 ` Mark Brown
2013-09-10 17:44 ` Stephen Warren
2013-09-10 18:07 ` Guenter Roeck
2013-09-10 18:18 ` Mark Brown
2013-09-10 18:37 ` Stephen Warren
2013-09-10 18:52 ` Mark Brown
2013-09-11 11:35 ` Wei Ni
2013-09-10 17:05 ` Mark Brown
2013-09-09 10:29 ` [PATCH v3 2/2] Documentation: dt: hwmon: add OF document for LM90 Wei Ni
2013-09-09 10:52 ` Guenter Roeck
2013-09-09 22:14 ` Stephen Warren [this message]
2013-09-10 4:25 ` Wei Ni
2013-09-09 10:57 ` Ramkumar Ramachandra
2013-09-10 4:35 ` Wei Ni
2013-09-10 4:36 ` Wei Ni
2013-09-09 22:15 ` Stephen Warren
2013-09-09 22:23 ` Guenter Roeck
2013-09-10 4:25 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522E4854.1050800@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=broonie@kernel.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).