linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wei Ni <wni@nvidia.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: "khali@linux-fr.org" <khali@linux-fr.org>,
	Guenter Roeck <linux@roeck-us.net>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] Documentation: dt: hwmon: add OF document for LM90
Date: Tue, 10 Sep 2013 12:35:03 +0800	[thread overview]
Message-ID: <522EA177.6050608@nvidia.com> (raw)
In-Reply-To: <CALkWK0nqgF6yn4QRe2tTD-Qd+5GLtH-ifCesayk-+uxkWMx-5w@mail.gmail.com>

On 09/09/2013 06:57 PM, Ramkumar Ramachandra wrote:
> Wei Ni wrote:
>> diff --git a/Documentation/devicetree/bindings/hwmon/lm90.txt b/Documentation/devicetree/bindings/hwmon/lm90.txt
>> new file mode 100644
>> index 0000000..5570875
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/lm90.txt
> 
> While at it, please update and rename ads1015.txt.

This series is for lm90 compatible devices, it seems ads1015 is not
register-compatible with lm90.

> 
>> @@ -0,0 +1,44 @@
>> +* LM90 series thermometer.
>> +
>> +Required node properties:
>> +- compatible: manufacture and chip name, one of
>> +               "<manufacture>,adm1032"
>> +               "<manufacture>,adt7461"
>> +               "<manufacture>,adt7461a"
>> +               "<manufacture>,g781"
>> +               "<manufacture>,lm90"
>> +               "<manufacture>,lm86"
>> +               "<manufacture>,lm89"
>> +               "<manufacture>,lm99"
> 
> More versions of this of different ages are required.

In here, the chip names, such as "lm99", come from lm90.c id_table, the
i2c subsystem want to use it to load driver, so we can add any other names.

> 
>> +               "<manufacture>,max6646"
>> +               "<manufacture>,max6647"
>> +               "<manufacture>,max6649"
>> +               "<manufacture>,max6657"
>> +               "<manufacture>,max6658"
>> +               "<manufacture>,max6659"
>> +               "<manufacture>,max6680"
>> +               "<manufacture>,max6681"
>> +               "<manufacture>,max6695"
>> +               "<manufacture>,max6696"
> 
> SSDNow devices are required.
What's the SSDNow device? It seems the lm90.c doesn't support it.

Thanks.
Wei.

> 


  reply	other threads:[~2013-09-10  4:34 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-09 10:29 [PATCH v3 0/2] Add power control for lm90 Wei Ni
2013-09-09 10:29 ` [PATCH v3 1/2] hwmon: (lm90) Add power control Wei Ni
2013-09-09 11:12   ` Mark Brown
2013-09-09 11:34     ` Guenter Roeck
2013-09-09 13:50       ` Mark Brown
2013-09-09 15:50         ` Guenter Roeck
2013-09-09 16:02           ` Mark Brown
2013-09-09 16:17             ` Guenter Roeck
2013-09-09 20:39               ` Mark Brown
2013-09-10  4:05                 ` Wei Ni
2013-09-10  4:50                   ` Guenter Roeck
2013-09-10  5:39                     ` Wei Ni
2013-09-10  5:54                       ` Guenter Roeck
2013-09-10  6:30                         ` Wei Ni
2013-09-10 10:13                       ` Mark Brown
2013-09-10 11:29                         ` Wei Ni
2013-09-10 12:11                           ` Mark Brown
2013-09-11  9:40                             ` Wei Ni
2013-09-10  3:22           ` Wei Ni
2013-09-10  3:36             ` Guenter Roeck
2013-09-10  3:40               ` Stephen Warren
2013-09-10  3:53                 ` Guenter Roeck
2013-09-10  4:12                   ` Wei Ni
2013-09-10  4:13                   ` Stephen Warren
2013-09-10  4:44                     ` Guenter Roeck
2013-09-10 10:09                     ` Mark Brown
2013-09-10 15:07                       ` Stephen Warren
2013-09-10 17:04                         ` Mark Brown
2013-09-10 17:44                           ` Stephen Warren
2013-09-10 18:07                             ` Guenter Roeck
2013-09-10 18:18                             ` Mark Brown
2013-09-10 18:37                               ` Stephen Warren
2013-09-10 18:52                                 ` Mark Brown
2013-09-11 11:35                                   ` Wei Ni
2013-09-10 17:05             ` Mark Brown
2013-09-09 10:29 ` [PATCH v3 2/2] Documentation: dt: hwmon: add OF document for LM90 Wei Ni
2013-09-09 10:52   ` Guenter Roeck
2013-09-09 22:14     ` Stephen Warren
2013-09-10  4:25       ` Wei Ni
2013-09-09 10:57   ` Ramkumar Ramachandra
2013-09-10  4:35     ` Wei Ni [this message]
2013-09-10  4:36       ` Wei Ni
2013-09-09 22:15   ` Stephen Warren
2013-09-09 22:23     ` Guenter Roeck
2013-09-10  4:25       ` Wei Ni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522EA177.6050608@nvidia.com \
    --to=wni@nvidia.com \
    --cc=artagnon@gmail.com \
    --cc=broonie@kernel.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).