From: wwang <wei_wang@realsil.com.cn>
To: Lee Jones <lee.jones@linaro.org>
Cc: <sameo@linux.intel.com>, <devel@linuxdriverproject.org>,
<linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>,
<rogerable@realtek.com>, <micky_ching@realsil.com.cn>
Subject: Re: [PATCH v3] mfd: rtsx: Modify rts5249_optimize_phy
Date: Tue, 10 Sep 2013 17:58:18 +0800 [thread overview]
Message-ID: <522EED3A.9080806@realsil.com.cn> (raw)
In-Reply-To: <20130910092857.GB1456@lee--X1>
于 2013年09月10日 17:28, Lee Jones 写道:
> I would like some more information in the commit log though. You're
> making a lot of configuration changes here and due to the
> incomprehensible 'magic numbers' used previously, it's impossible to
> know what you're changing by just reading the code.
>
> Why won't the rts**** be initialise properly and what exactly are you
> changing to rectify the situation?
Hi Lee:
It's a little difficult to describe it very clearly. To put it simply,
the default setting of rts5249 is not good, and it will cause the signal
quality very bad. So we have to change those values to achieve a better
signal quality.
Do I need amend the commit and add the above description and resend it ?
BR,
Wei
next prev parent reply other threads:[~2013-09-10 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 9:13 [PATCH v3] mfd: rtsx: Modify rts5249_optimize_phy wei_wang
2013-09-10 9:28 ` Lee Jones
2013-09-10 9:58 ` wwang [this message]
2013-09-10 11:08 ` Lee Jones
2013-09-11 1:32 ` wwang
2013-09-13 7:28 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522EED3A.9080806@realsil.com.cn \
--to=wei_wang@realsil.com.cn \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox