From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: "rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"rob@landley.net" <rob@landley.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>
Subject: Re: [PATCH 2/2] regulator: core: add support for configuring turn-on time through constraints
Date: Tue, 10 Sep 2013 18:44:40 +0530 [thread overview]
Message-ID: <522F1B40.3040801@nvidia.com> (raw)
In-Reply-To: <20130910120922.GH29403@sirena.org.uk>
On Tuesday 10 September 2013 05:39 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Tue, Sep 10, 2013 at 04:48:08PM +0530, Laxman Dewangan wrote:
>
>> +- regulator-enable-time: Turn ON time for regulator(in uS)
> This is unclear - what is a "turn on time" and is this in addition to or
> separate from the underlying enable time of the device? It needs to be
> clear that this is the time taken for the voltage to ramp to spec. I'd
> also expect it to be clear that this is not something that should need
> to be provided normally.
Here my intention for turn-on time is the time from OFF state to ON
state and the ON voltage settled on this time.
This time is separate from underlying enable time of the device i.e.
will not get added.
We observe in some of platform that some of regulator is taking more
time than time given as per datasheet.
Yes, completely agree that this is not the data provided normally, just
we observe on scope that some of platform shows more than the datasheet
value and hence this patch.
The same rail on other design does not show the enable time more than
datasheet and on that case, we will not provide this value.
> Please ALSO avoid capitalising words FOR no reason.
>
>
My bad, will take care.
next prev parent reply other threads:[~2013-09-10 12:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 11:18 [PATCH 1/2] regulator: palmas: configure enable time for LDOs Laxman Dewangan
2013-09-10 11:18 ` [PATCH 2/2] regulator: core: add support for configuring turn-on time through constraints Laxman Dewangan
2013-09-10 12:09 ` Mark Brown
2013-09-10 13:14 ` Laxman Dewangan [this message]
2013-09-10 16:33 ` Mark Brown
2013-09-10 15:11 ` Stephen Warren
2013-09-10 16:51 ` Mark Brown
2013-09-10 17:34 ` Stephen Warren
2013-09-10 17:38 ` Mark Brown
2013-09-10 17:45 ` Stephen Warren
2013-09-10 18:19 ` Mark Brown
2013-09-10 12:10 ` [PATCH 1/2] regulator: palmas: configure enable time for LDOs Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522F1B40.3040801@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox