From: wwang <wei_wang@realsil.com.cn>
To: Lee Jones <lee.jones@linaro.org>
Cc: <sameo@linux.intel.com>, <devel@linuxdriverproject.org>,
<linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>,
<rogerable@realtek.com>, <micky_ching@realsil.com.cn>
Subject: Re: [PATCH v3] mfd: rtsx: Modify rts5249_optimize_phy
Date: Wed, 11 Sep 2013 09:32:28 +0800 [thread overview]
Message-ID: <522FC82C.4020000@realsil.com.cn> (raw)
In-Reply-To: <20130910110821.GD1456@lee--X1>
于 2013年09月10日 19:08, Lee Jones 写道:
> I'm not asking for in-depth analysis, just an overview.
>
> What's wrong with the default config?
> Why is the signal quality bad and what makes it bad?
> What did the old magic numbers do?
> How will the configuration differ if I applied your patch?
It is a little different between simulation and real chip. We have no idea about which configuration is better before tape-out. We set default settings according to simulation, but need to tune these parameters after getting the real chip.
Those old magic numbers are proper in simulation environment, but not good in real ASIC chip.
If the new patch won't be applied, we may failed to access SD card in those platforms equipped with rts5249 module.
next prev parent reply other threads:[~2013-09-11 1:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 9:13 [PATCH v3] mfd: rtsx: Modify rts5249_optimize_phy wei_wang
2013-09-10 9:28 ` Lee Jones
2013-09-10 9:58 ` wwang
2013-09-10 11:08 ` Lee Jones
2013-09-11 1:32 ` wwang [this message]
2013-09-13 7:28 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522FC82C.4020000@realsil.com.cn \
--to=wei_wang@realsil.com.cn \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox