From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, broonie@kernel.org
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
quic_srivasam@quicinc.com
Subject: Re: [PATCH v2 14/16] ASoC: codecs: wsa881x: add runtime pm support
Date: Thu, 24 Feb 2022 09:29:25 -0600 [thread overview]
Message-ID: <522ab282-ecc2-4186-2d77-f6241e255109@linux.intel.com> (raw)
In-Reply-To: <20220224111718.6264-15-srinivas.kandagatla@linaro.org>
On 2/24/22 05:17, Srinivas Kandagatla wrote:
> WSA881x codecs can not cope up with clk stop and requires a full reset after suspend.
> WSA SoundWire Controller connected to this instances do a full soft reset on suspend.
is it the manager or peripheral that cannot cope with clock stop?
> @@ -1124,6 +1136,7 @@ static int wsa881x_probe(struct sdw_slave *pdev,
> pdev->prop.sink_ports = GENMASK(WSA881X_MAX_SWR_PORTS, 0);
> pdev->prop.sink_dpn_prop = wsa_sink_dpn_prop;
> pdev->prop.scp_int1_mask = SDW_SCP_INT1_BUS_CLASH | SDW_SCP_INT1_PARITY;
> + pdev->prop.simple_clk_stop_capable = true;
here it's pretty clear the peripheral is capable of supporting clock
stop, no?
Something's not clear between the commit message and the code.
next prev parent reply other threads:[~2022-02-24 15:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 11:17 [PATCH v2 00/16] ASoC: codecs: add pm runtime support for Qualcomm codecs Srinivas Kandagatla
2022-02-24 11:17 ` [PATCH v2 01/16] ASoC: codecs: va-macro: move to individual clks from bulk Srinivas Kandagatla
2022-02-24 11:17 ` [PATCH v2 02/16] ASoC: codecs: rx-macro: move clk provider to managed variants Srinivas Kandagatla
2022-02-24 11:17 ` [PATCH v2 03/16] ASoC: codecs: tx-macro: " Srinivas Kandagatla
2022-02-24 11:17 ` [PATCH v2 04/16] ASoC: codecs: rx-macro: move to individual clks from bulk Srinivas Kandagatla
2022-02-24 11:17 ` [PATCH v2 05/16] ASoC: codecs: tx-macro: " Srinivas Kandagatla
2022-02-24 11:17 ` [PATCH v2 06/16] ASoC: codecs: wsa-macro: " Srinivas Kandagatla
2022-02-24 11:17 ` [PATCH v2 07/16] ASoC: codecs: wsa-macro: setup soundwire clks correctly Srinivas Kandagatla
2022-02-24 11:17 ` [PATCH v2 08/16] ASoC: codecs: tx-macro: " Srinivas Kandagatla
2022-02-24 11:17 ` [PATCH v2 09/16] ASoC: codecs: rx-macro: " Srinivas Kandagatla
2022-02-24 11:17 ` [PATCH v2 10/16] ASoC: codecs: va-macro: add runtime pm support Srinivas Kandagatla
2022-02-24 11:17 ` [PATCH v2 11/16] ASoC: codecs: wsa-macro: " Srinivas Kandagatla
2022-02-24 11:17 ` [PATCH v2 12/16] ASoC: codecs: rx-macro: " Srinivas Kandagatla
2022-02-24 11:17 ` [PATCH v2 13/16] ASoC: codecs: tx-macro: " Srinivas Kandagatla
2022-02-24 11:17 ` [PATCH v2 14/16] ASoC: codecs: wsa881x: " Srinivas Kandagatla
2022-02-24 15:29 ` Pierre-Louis Bossart [this message]
2022-02-24 16:13 ` Srinivas Kandagatla
2022-02-24 11:17 ` [PATCH v2 15/16] ASoC: codecs: wcd938x: add simple clk stop support Srinivas Kandagatla
2022-02-24 11:17 ` [PATCH v2 16/16] ASoC: codecs: wcd-mbhc: add runtime pm support Srinivas Kandagatla
2022-02-25 17:35 ` (subset) [PATCH v2 00/16] ASoC: codecs: add pm runtime support for Qualcomm codecs Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522ab282-ecc2-4186-2d77-f6241e255109@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_srivasam@quicinc.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox