From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934104AbbJHPLt (ORCPT <rfc822;w@1wt.eu>);
	Thu, 8 Oct 2015 11:11:49 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:61444 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933667AbbJHPLq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 8 Oct 2015 11:11:46 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: David Daney <ddaney.cavm@gmail.com>, linux-kernel@vger.kernel.org,
        Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        Will Deacon <will.deacon@arm.com>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        Marc Zyngier <marc.zyngier@arm.com>,
        David Daney <david.daney@cavium.com>
Subject: Re: [PATCH v4 4/5] PCI: generic: Correct, and avoid overflow, in bus_max calculation.
Date: Thu, 08 Oct 2015 17:11:32 +0200
Message-ID: <5230007.h2fkbnOlh5@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <20151008150243.GC3885@localhost>
References: <1443811443-18878-1-git-send-email-ddaney.cavm@gmail.com> <1443811443-18878-5-git-send-email-ddaney.cavm@gmail.com> <20151008150243.GC3885@localhost>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:t97fkXWUfvDT6lWo4Pz/EmFClQuCrzpvxlmx53seYtmxVMd6wga
 5E2ATyPCB5wQKoG9JBoNzVBEIA79grbl+/a91rnGtq1Bc6jc7W75S0hd9qfj9LUKV57VL39
 TFio9dT4EXQHVIkgrt4hdXDt7rZByoY1/JA+ztQURfdwc96WHe4gCiAuPxUw9w7U6z6LD5+
 g1/C2x5gDaxStkB+tvktA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:cDRemlqinE8=:hrikL2qJ00dFXe+OqIiwIV
 /nR0sf/ZI9PAZDuT8c4+Fo40AefHbj6LrEpY5MszuaNKWkypFpwkTpWCHAd9LKiMuhJqqFHZ6
 bMSkM/EwNX0uNrYyJzwTPiJ1pouID7kb6CA5sgXE4zkT7kobMr6Kj1HW39jKwDTdPNKfaluaF
 09t3jZjID3gE+WGxU/JAyVdIRVY7HWW4wUVJ1mgdY3O5JnifesmwvTLX6EIeK08Q7HlkeJBDe
 74kcAc4iQtO3UvmUmJfELXAkwKAD18bDWJQpxP29MoVJCLTm3KoFm3BCMlLjwDkc5kazgdv79
 67J+M3x+38x9brZZyUEviWzLW4oYlLS3vtmfvnQhbfnCrsrKG62n4wuXqlfnF7yb4l3PCm/FA
 z2EXN5AtlXHuycjSdwo2yrG1btiZagX59LhiQOYee8KNzLIbOiKNPmomB0ELeKlK4rE5WCUoz
 pDIhN/Kxlk1gec2ZoDTWiT7GdADCjKW+8VAqQbVDBLkpMG16MgBsXEWmCHWZ78wxBkJWtnk/c
 V3uabMpM0YPJA4ZF0hjqhnfqDvttcvFoIlSgqCp2MIri6e6J17iJ2u73kNo42xKh3qsib41ah
 +N2HCcb2aklyRjZxFxyrYL8rFdTEcg0my9AiURERYwy238z2B8Qmh5tnizGKZPGETfd9323Eh
 LGW2vxnEme9MV/qWdm3Fbto5ICmxg+hEdcrXJoT62kCBA07dwTRdaWz60O9is9sQrM6xLdNq+
 igpdQPX9i3EKdOVb
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday 08 October 2015 10:02:43 Bjorn Helgaas wrote:
> [+cc Arnd]
> 
> And this one?

Not so good.

> > --- a/Documentation/devicetree/bindings/pci/host-generic-pci.txt
> > +++ b/Documentation/devicetree/bindings/pci/host-generic-pci.txt
> > @@ -34,7 +34,11 @@ Properties of the host controller node:
> >  - #size-cells    : Must be 2.
> >  
> >  - reg            : The Configuration Space base address and size, as accessed
> > -                   from the parent bus.
> > +                   from the parent bus.  The base address corresponds to
> > +                   bus zero, even though the "bus-range" property may specify
> > +                   a different starting bus number.  The driver must only map
> > +                   or access the portion of the Configuration Space that
> > +                   corresponds to the "bus-range"

I thought we had reached an agreement that it is a bad idea to have a 'reg'
property that lists registers belonging to a different device.

	Arnd