From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1423742AbcFMO7g (ORCPT <rfc822;w@1wt.eu>);
	Mon, 13 Jun 2016 10:59:36 -0400
Received: from mout.kundenserver.de ([212.227.17.10]:64613 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752405AbcFMO7f (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 13 Jun 2016 10:59:35 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: Sage Weil <sage@redhat.com>, Jan Beulich <jbeulich@suse.com>,
        Michal Marek <mmarek@suse.cz>, "Yan, Zheng" <zyan@redhat.com>,
        Alex Elder <elder@linaro.org>,
        Ceph Development <ceph-devel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ceph: fix symbol versioning for ceph_monc_do_statfs
Date: Mon, 13 Jun 2016 16:59:49 +0200
Message-ID: <5230458.e005FX3QRC@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <CAOi1vP9twC4r6wwuHV0FAcwBoYhELfdrLjjAfNDzMh==akKeJQ@mail.gmail.com>
References: <1465823125-171114-1-git-send-email-arnd@arndb.de> <CAOi1vP9twC4r6wwuHV0FAcwBoYhELfdrLjjAfNDzMh==akKeJQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:6dBA6vQSPV7w+q0mmRkSHuYtfSwP1RHOUMsJxNVGsk5EfZgdvYZ
 O/g8ZhGb/xZet4G2JMlJMLhHzREohpmkCAVQp/d+ziInSpZS7OTdtM/EsH2qh3uxhakI9bb
 bYvzu/tcPVogn+FBdggL06qgF4KNIi/koYavJvL/z1g8Ef0U8sIoX2j9M7irm9cBpQGs4Ru
 gJZ/Z4v/11zjFjQt26dbA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:zjuLoA56aIM=:li8lFS467U72B2xV95s75Y
 apKuj5HuO1ZYkTHuIliwqG6qY/lm8O49RzGE/IBrDwSoWU3hDn+jb/dNAgxvlCgDPZVd+vwYI
 yG9tY/olwy0a6nr4hAsPlYQfMyZcUuc2GiWVVRPOa4vNjR/dALfsskcrvudkEbRkMMHYqD1j4
 yqQ3WT6Ay8i58BuhkmRRTBdyqlBqmW6vuZSK6NXlWn0m6hsjkO7whO0+bWUPU0Zyt39ADyqkO
 nPuEFExISsbkX8BgTWd82NZis1mUBuHB6zHnEq7JQOO0E0zu1IXOQuIdVN5impPp8jK9evWYM
 d5sbhD4iwLV/EPPPqSuOvs6yaWl0ibCEPBXcCXmmTqt9JpD2UewV/Qt/mH4lHX2w58kPZ5YuF
 ShVOc3H7abNdf0CFyrc7Z9EA2DbKVVwzDwpmoshFu0LIaIn5CzlQMk5PiycM8Zv/XHLoBChkH
 0gFMTTyQgd13Z6vMuGSO+er+jm0xjG28r1Nwz2NN6VuVPW7z8ix8IGI5GRn6bS9d2cvoAPTAQ
 mXMo2Wyncv+/G/1/L36dVlsF5CqGiCW2gkg9hqFKml1E2donvLD7nay15sKGVTduBPrGXsxQp
 G1MUpJR+3X/NMLiY53WWZ49xSrjhNbccdMNBU8Kkp93TnsmG7wnPvWOjOcW5gRVPTrvK4ejW+
 Zamw0AJqG79zTjeVHB8Rk4ZlaNcmPSM7v8iVy+ChooPk8hlqH7t6B9YMqyJMdrJl0Pq/qAdWA
 mUdT4INsOFzHU8s+
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, June 13, 2016 3:19:12 PM CEST Ilya Dryomov wrote:
> > diff --git a/include/linux/ceph/libceph.h b/include/linux/ceph/libceph.h
> > index 690985daad1c..6b79a6ba39ca 100644
> > --- a/include/linux/ceph/libceph.h
> > +++ b/include/linux/ceph/libceph.h
> > @@ -214,8 +214,9 @@ static void erase_##name(struct rb_root *root, type *t)                     \
> >  }
> >
> >  #define DEFINE_RB_LOOKUP_FUNC(name, type, keyfld, nodefld)             \
> > +extern type __lookup_##name##_key;                                     \
> >  static type *lookup_##name(struct rb_root *root,                       \
> > -                          typeof(((type *)0)->keyfld) key)             \
> > +                          typeof(__lookup_##name##_key.keyfld) key)    \
> >  {                                                                      \
> >         struct rb_node *n = root->rb_node;                              \
> >                                                                         \
> 
> Out of curiosity, did you figure out why is it that only
> ceph_monc_do_statfs() is affected and not the other exports in
> net/ceph/osd_client.c?

No, I did not investigate it further at that point. My guess is that
something resets the state of the genksyms parser when it encounters
some tokens (like the semicolon I added earlier, or an EXPORT_SYMBOL
statement), and that this happens in one file but not the other.

	Arnd