Re: [PATCH] kobject: introduce kobj_completion

[Jeff Mahoney <jeffm@suse.com>]

[-- Attachment #1: Type: text/plain, Size: 868 bytes --]

On 9/11/13 1:15 PM, Greg KH wrote:
> On Wed, Sep 11, 2013 at 01:00:30PM -0400, Jeff Mahoney wrote:
>> A common way to handle kobject lifetimes in embedded in objects with
>> different lifetime rules is to pair the kobject with a struct completion.
>>
>> This introduces a kobj_completion structure that can be used in place
>> of the pairing, along with several convenience functions for
>> initialization, release, and put-and-wait.
>>
>> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
>> ---
>>  include/linux/kobj_completion.h |   18 ++++++++++++++
> 
> Does this really need a new .h file, or can we just cram it into
> kobject.h?  It's only 13 more lines to add to that file.

It doesn't need to be, but it avoids everywhere that already uses a
kobject having to include <linux/completion.h> indirectly.

-Jeff

-- 
Jeff Mahoney
SUSE Labs


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 841 bytes --]