From: Suman Anna <s-anna@ti.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
"'Joerg Roedel'" <joro@8bytes.org>,
<linux-kernel@vger.kernel.org>,
<iommu@lists.linux-foundation.org>
Subject: Re: [PATCH] iommu/omap: Remove casting the return value which is a void pointer
Date: Thu, 12 Sep 2013 17:30:11 -0500 [thread overview]
Message-ID: <52324073.8090101@ti.com> (raw)
In-Reply-To: <005601cead1e$ffe78470$ffb68d50$%han@samsung.com>
On 09/09/2013 12:39 AM, Jingoo Han wrote:
> Casting the return value which is a void pointer is redundant.
> The conversion from void pointer to any other pointer type is
> guaranteed by the C programming language.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Thanks, LGTM.
> ---
> drivers/iommu/omap-iopgtable.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/omap-iopgtable.h b/drivers/iommu/omap-iopgtable.h
> index f4003d5..b6f9a51 100644
> --- a/drivers/iommu/omap-iopgtable.h
> +++ b/drivers/iommu/omap-iopgtable.h
> @@ -95,4 +95,4 @@ static inline phys_addr_t omap_iommu_translate(u32 d, u32 va, u32 mask)
> #define iopte_offset(iopgd, da) (iopgd_page_vaddr(iopgd) + iopte_index(da))
>
> #define to_iommu(dev) \
> - ((struct omap_iommu *)platform_get_drvdata(to_platform_device(dev)))
> + (platform_get_drvdata(to_platform_device(dev)))
>
prev parent reply other threads:[~2013-09-12 22:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 5:39 [PATCH] iommu/omap: Remove casting the return value which is a void pointer Jingoo Han
2013-09-12 22:30 ` Suman Anna [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52324073.8090101@ti.com \
--to=s-anna@ti.com \
--cc=akpm@linux-foundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jg1.han@samsung.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox