linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Michal Simek <michal.simek@xilinx.com>,
	linux-kernel@vger.kernel.org,
	Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] dma: pl330: Simplify irq allocation
Date: Fri, 13 Sep 2013 11:33:33 +0200	[thread overview]
Message-ID: <5232DBED.5060903@monstr.eu> (raw)
In-Reply-To: <20130912134208.GE17188@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]

On 09/12/2013 03:42 PM, Vinod Koul wrote:
> On Wed, Sep 04, 2013 at 04:40:17PM +0200, Michal Simek wrote:
>> Use devm_request_irq function.
> 
> Applied, thanks

Thanks. I have one change in my tree which I would like to get to the mainline
but it will need more interaction with others pl330 users.
It is about adding support for interrupt per channel feature.
For our case we have 8 channels and every channel has specific interrupt
+ we have one abort IRQ.

Based on the binding and Linux code two changes are necessary.
1. Extend AMBA_NR_IRQS because we have 9 IRQs
2. Driver change which is just register irqs when they are available.

Are these two changes OK for you?

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  reply	other threads:[~2013-09-13  9:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-04 14:40 [PATCH] dma: pl330: Simplify irq allocation Michal Simek
2013-09-12 13:42 ` Vinod Koul
2013-09-13  9:33   ` Michal Simek [this message]
2013-09-17  7:07     ` Vinod Koul
  -- strict thread matches above, loose matches on Subject: below --
2013-09-12  5:41 Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5232DBED.5060903@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).