From: "H. Peter Anvin" <hpa@zytor.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
mingo@kernel.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf/x86/intel: Clean-up/reduce PEBS code
Date: Mon, 16 Sep 2013 01:17:45 -0500 [thread overview]
Message-ID: <5236A289.2010007@zytor.com> (raw)
In-Reply-To: <20130916060736.GN21832@twins.programming.kicks-ass.net>
On 09/16/2013 01:07 AM, Peter Zijlstra wrote:
> On Fri, Sep 13, 2013 at 11:18:21PM -0700, Andi Kleen wrote:
>> tip-bot for Peter Zijlstra <tipbot@zytor.com> writes:
>>> +
>>> + at = (struct pebs_record_nhm *)(unsigned long)ds->pebs_buffer_base;
>>> + top = (struct pebs_record_nhm *)(unsigned long)ds->pebs_index;
>>>
>>> ds->pebs_index = ds->pebs_buffer_base;
>>>
>>> + n = (top - at) / x86_pmu.pebs_record_size;
>>
>>
>> This adds a full slow division to the PEBS hot path.
>>
>> Does not seem like a improvement to me.
>
> There already was an implicit division there, and
> sizeof(pebs_record_hsw) = 176, can it really optimize that constant
> division?
>
gcc can optimize ANY constant division, if nothing else then by
reciprocal multiplication.
-hpa
next prev parent reply other threads:[~2013-09-16 6:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 18:04 [tip:perf/core] perf/x86/intel: Clean-up/reduce PEBS code tip-bot for Peter Zijlstra
2013-09-14 6:18 ` Andi Kleen
2013-09-16 6:07 ` Peter Zijlstra
2013-09-16 6:17 ` H. Peter Anvin [this message]
2013-09-16 7:24 ` Peter Zijlstra
2013-09-16 16:09 ` Andi Kleen
2013-09-16 16:03 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5236A289.2010007@zytor.com \
--to=hpa@zytor.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox