From: Benoit Cousson <bcousson@baylibre.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Koen Kooi <koen@dominion.thruhere.net>,
linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org,
ijc+devicetree@hellion.org.uk, linux@arm.linux.org.uk,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/4] ARM: dts: am335x-boneblack: add eMMC DT entry
Date: Tue, 17 Sep 2013 15:26:33 +0200 [thread overview]
Message-ID: <52385889.4090200@baylibre.com> (raw)
In-Reply-To: <20130913152705.GN7189@atomide.com>
Hi Tony,
On 13/09/2013 17:27, Tony Lindgren wrote:
> * Koen Kooi <koen@dominion.thruhere.net> [130912 11:43]:
>> The pinmux is specified in am335x-bone-common.dtsi to be reused by the eMMC cape.
>>
>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>> ---
>> arch/arm/boot/dts/am335x-bone-common.dtsi | 22 ++++++++++++++++++++++
>> arch/arm/boot/dts/am335x-boneblack.dts | 14 ++++++++++++++
>> 2 files changed, 36 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
>> index 0d95d54..bc8d1a2 100644
>> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
>> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
>> @@ -113,6 +113,21 @@
>> 0x160 (PIN_INPUT | MUX_MODE7) /* GPIO0_6 */
>> >;
>> };
>> +
>> + emmc_pins: pinmux_emmc_pins {
>> + pinctrl-single,pins = <
>> + 0x80 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn1.mmc1_clk, INPUT_PULLUP | MODE2 */
>> + 0x84 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_csn2.mmc1_cmd, INPUT_PULLUP | MODE2 */
>> + 0x00 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad0.mmc1_dat0, INPUT_PULLUP | MODE1 */
>> + 0x04 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad1.mmc1_dat1, INPUT_PULLUP | MODE1 */
>> + 0x08 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad2.mmc1_dat2, INPUT_PULLUP | MODE1 */
>> + 0x0c (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad3.mmc1_dat3, INPUT_PULLUP | MODE1 */
>> + 0x10 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad4.mmc1_dat4, INPUT_PULLUP | MODE1 */
>> + 0x14 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad5.mmc1_dat5, INPUT_PULLUP | MODE1 */
>> + 0x18 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad6.mmc1_dat6, INPUT_PULLUP | MODE1 */
>> + 0x1c (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad7.mmc1_dat7, INPUT_PULLUP | MODE1 */
>> + >;
>> + };
>> };
>>
>> ocp {
>
> Here you can now use just the defines to make it a bit shorter:
>
> 0x80 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn1.mmc1_clk */
Considering that Koen has just disappeared for a 3 weeks honeymoon, I'll
fix the patch. GIT does complain about various trailing spaces and end
of file issue for this patch as well :-(
Regards,
Benoit
next prev parent reply other threads:[~2013-09-17 13:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 18:35 [PATCH v4 0/2] ARM: dts: Beaglebone MMC fixes Koen Kooi
2013-09-12 18:35 ` [PATCH v4 1/4] ARM: dts: am335x-bone: add CD for mmc1 Koen Kooi
2013-09-28 3:13 ` Jason Kridner
2013-09-12 18:35 ` [PATCH v4 2/4] ARM: dts: am335x-boneblack: add eMMC DT entry Koen Kooi
2013-09-13 15:27 ` Tony Lindgren
2013-09-17 13:26 ` Benoit Cousson [this message]
2013-09-12 18:35 ` [PATCH v4 3/4] ARM: dts: am335x-bone-common: switch mmc1 to 4-bit mode Koen Kooi
2013-09-12 18:35 ` [PATCH v4 4/4] ARM: dts: am335x-bone-common: add cpu0 and mmc1 triggers Koen Kooi
2013-09-12 19:21 ` [PATCH v4 0/2] ARM: dts: Beaglebone MMC fixes Nishanth Menon
2013-09-12 22:27 ` Kevin Hilman
2013-09-13 9:19 ` Koen Kooi
2013-09-17 13:30 ` Benoit Cousson
2013-10-25 9:04 ` Richard Cochran
2013-10-25 9:10 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52385889.4090200@baylibre.com \
--to=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=koen@dominion.thruhere.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).