From: Mike Dunn <mikedunn@newsguy.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: thierry.reding@gmail.com, Richard Purdie <rpurdie@rpsys.net>,
Jingoo Han <jg1.han@samsung.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Robert Jarzmik <robert.jarzmik@free.fr>,
Marek Vasut <marex@denx.de>
Subject: Re: [PATCH] pwm-backlight: allow for non-increasing brightness levels
Date: Tue, 17 Sep 2013 07:23:26 -0700 [thread overview]
Message-ID: <523865DE.3030406@newsguy.com> (raw)
In-Reply-To: <20130917093622.GB30088@pengutronix.de>
On 09/17/2013 02:36 AM, Sascha Hauer wrote:
> Hi Mike,
>
> On Thu, Sep 12, 2013 at 11:35:52AM -0700, Mike Dunn wrote:
>> Currently the driver assumes that the values specified in the brightness-levels
>> device tree property increase as they are parsed from left to right. But boards
>> that invert the signal between the PWM output and the backlight will need to
>> specify decreasing brightness-levels. This patch removes the assumption that
>> the last element of the array is the max value, and instead searches the array
>> for the max value and uses that as the normalizing value when determining the
>> duty cycle.
>
> Note there's also support for inverted PWMs in the PWM framework
> provided your hardware supports this.
Yes, and in fact my first solution was to implement simulated polarity inversion
in the pwm driver, but that was shot down because polarity inversion is not
actually supported by the pwm hardware. My inverter is external in the path
between the pwm output and the backlight. Not sure of the reason for its presence.
Thanks,
Mike
next prev parent reply other threads:[~2013-09-17 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 18:35 [PATCH] pwm-backlight: allow for non-increasing brightness levels Mike Dunn
2013-09-17 9:36 ` Sascha Hauer
2013-09-17 14:23 ` Mike Dunn [this message]
2013-09-19 11:56 ` Thierry Reding
2013-09-19 16:13 ` Mike Dunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523865DE.3030406@newsguy.com \
--to=mikedunn@newsguy.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jg1.han@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=marex@denx.de \
--cc=plagnioj@jcrosoft.com \
--cc=rob.herring@calxeda.com \
--cc=robert.jarzmik@free.fr \
--cc=rpurdie@rpsys.net \
--cc=s.hauer@pengutronix.de \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox