From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752901Ab3IQO3L (ORCPT ); Tue, 17 Sep 2013 10:29:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57816 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752270Ab3IQO3J (ORCPT ); Tue, 17 Sep 2013 10:29:09 -0400 Message-ID: <52386730.4060508@suse.de> Date: Tue, 17 Sep 2013 16:29:04 +0200 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Doug Ledford Cc: Paul Gortmaker , linux-scsi list , linux-kernel@vger.kernel.org, "James E.J. Bottomley" Subject: Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver References: In-Reply-To: X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/17/2013 04:13 AM, Doug Ledford wrote: > Yes, this driver is well past ready to be removed. > > Acked-by: Doug Ledford > > Sent from my ASUS Pad > > Paul Gortmaker wrote: > >> After getting warnings in an allyesconfig build[1] from this >> driver, I decided to remind myself just how old it was, and >> whether it warranted fixing. In the Kconfig help text, I found: >> >> "This driver will eventually be phased out entirely" >> >> Going back to the history archive, I see the line was added[2] >> in Feb 2002, when we moved from v2.4.2.1 ---> v2.4.2.2 >> >> So, with over a decade of notification, and multiple major releases >> since then, I think we can justify removing this. Currently we have >> people wasting time building it during routine testing, and then >> wasting more time re-researching the known reported warnings, only to >> find that nobody really is willing to integrate the fixes[3] for it. >> >> A quick search didn't seem to indicate any active user base for it. >> If someone happens to have a quirky _old_ card that the eleven year >> old "new" driver doesn't work with, then it is entirely reasonable >> that they stick with a kernel version that predates this removal. >> >> [1] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_register’: >> drivers/scsi/aic7xxx_old.c:7901:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] >> drivers/scsi/aic7xxx_old.c:7898:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] >> drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_load_seeprom’: >> drivers/scsi/aic7xxx_old.c:8517:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] >> drivers/scsi/aic7xxx_old.c:8510:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] >> >> [2] http://git.kernel.org/cgit/linux/kernel/git/tglx/history.git commit 44e8778c >> >> [3] https://lkml.org/lkml/2012/10/29/215 >> >> Cc: Hannes Reinecke >> Cc: Doug Ledford >> Cc: "James E.J. Bottomley" >> Signed-off-by: Paul Gortmaker However, if we do this we're removing support for any non-PCI based adapters. I personally doubt that there are any installations left running on (E)ISA or VLB. But we should be clear on this. In general I'm in favour removing obsolete drivers, so Acked-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)