From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: linux-kernel@vger.kernel.org,
Paul Gortmaker <paul.gortmaker@windriver.com>,
stable@vger.kernel.org, kvm@vger.kernel.org, gleb@redhat.com
Subject: Re: [PATCH 1/3] KVM: cleanup (physical) CPU hotplug
Date: Wed, 18 Sep 2013 01:19:33 +0200 [thread overview]
Message-ID: <5238E385.1050705@redhat.com> (raw)
In-Reply-To: <52380B55.5010408@siemens.com>
Il 17/09/2013 09:57, Jan Kiszka ha scritto:
>> > Remove the useless argument, and do not do anything if there are no
>> > VMs running at the time of the hotplug.
> kvm_cpu_hotplug already filters !kvm_usage_count. If we need the check
> to be under kvm_lock, drop that line as well. If that is not required
> (machine still halted?), drop the related changes here.
CPU_DYING is called under stop_machine, CPU_STARTING is not. So I
should drop the test in kvm_cpu_hotplug. It's a bit clearer anyway to
not rely on stop_machine.
Paolo
next prev parent reply other threads:[~2013-09-17 23:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 14:06 [PATCH 0/3] KVM: Make kvm_lock non-raw Paolo Bonzini
2013-09-16 14:06 ` [PATCH 1/3] KVM: cleanup (physical) CPU hotplug Paolo Bonzini
2013-09-17 7:57 ` Jan Kiszka
2013-09-17 23:19 ` Paolo Bonzini [this message]
2013-09-16 14:06 ` [PATCH 2/3] KVM: protect kvm_usage_count with its own spinlock Paolo Bonzini
2013-09-16 14:06 ` [PATCH 3/3] KVM: Convert kvm_lock back to non-raw spinlock Paolo Bonzini
2013-09-16 22:12 ` [PATCH 0/3] KVM: Make kvm_lock non-raw Paul Gortmaker
2013-09-20 17:51 ` Paul Gortmaker
2013-09-20 18:04 ` Jan Kiszka
2013-09-20 18:18 ` Paul Gortmaker
2013-09-20 18:27 ` Jan Kiszka
2013-09-21 20:26 ` Michael S. Tsirkin
2013-09-22 7:42 ` Gleb Natapov
2013-09-22 8:53 ` Paolo Bonzini
2013-09-22 9:53 ` Gleb Natapov
2013-09-23 6:30 ` Jan Kiszka
2013-09-23 13:36 ` Paul Gortmaker
2013-09-23 13:44 ` Paolo Bonzini
2013-09-23 14:59 ` Gleb Natapov
2013-09-23 15:05 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5238E385.1050705@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).