* [PATCH] clocksource: fix comment for __clocksource_updatefreq_scale
@ 2013-09-17 10:40 Xie XiuQi
2013-09-17 18:57 ` Thomas Gleixner
0 siblings, 1 reply; 3+ messages in thread
From: Xie XiuQi @ 2013-09-17 10:40 UTC (permalink / raw)
To: John Stultz, Thomas Gleixner, Ingo Molnar; +Cc: linux-kernel@vger.kernel.org
The functions clocksource_updatefreq_hz() and clocksource_updatefreq_khz()
do not exist, The proper ones are __clocksource_updatefreq_hz() and
__clocksource_updatefreq_khz().
Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
---
kernel/time/clocksource.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index 50a8736..d2f6ddc 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -714,7 +714,8 @@ static void clocksource_enqueue(struct clocksource *cs)
* This should only be called from the clocksource->enable() method.
*
* This *SHOULD NOT* be called directly! Please use the
- * clocksource_updatefreq_hz() or clocksource_updatefreq_khz helper functions.
+ * __clocksource_updatefreq_hz() or __clocksource_updatefreq_khz helper
+ * functions.
*/
void __clocksource_updatefreq_scale(struct clocksource *cs, u32 scale, u32 freq)
{
--
1.8.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clocksource: fix comment for __clocksource_updatefreq_scale
2013-09-17 10:40 [PATCH] clocksource: fix comment for __clocksource_updatefreq_scale Xie XiuQi
@ 2013-09-17 18:57 ` Thomas Gleixner
2013-09-18 1:48 ` Xie XiuQi
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Gleixner @ 2013-09-17 18:57 UTC (permalink / raw)
To: Xie XiuQi; +Cc: John Stultz, Ingo Molnar, linux-kernel@vger.kernel.org
On Tue, 17 Sep 2013, Xie XiuQi wrote:
> The functions clocksource_updatefreq_hz() and clocksource_updatefreq_khz()
> do not exist, The proper ones are __clocksource_updatefreq_hz() and
> __clocksource_updatefreq_khz().
I'd rather rename the functions and the few call sites because the
underscores are completely meaningless.
Thanks,
tglx
> Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
> ---
> kernel/time/clocksource.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
> index 50a8736..d2f6ddc 100644
> --- a/kernel/time/clocksource.c
> +++ b/kernel/time/clocksource.c
> @@ -714,7 +714,8 @@ static void clocksource_enqueue(struct clocksource *cs)
> * This should only be called from the clocksource->enable() method.
> *
> * This *SHOULD NOT* be called directly! Please use the
> - * clocksource_updatefreq_hz() or clocksource_updatefreq_khz helper functions.
> + * __clocksource_updatefreq_hz() or __clocksource_updatefreq_khz helper
> + * functions.
> */
> void __clocksource_updatefreq_scale(struct clocksource *cs, u32 scale, u32 freq)
> {
> --
> 1.8.2.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clocksource: fix comment for __clocksource_updatefreq_scale
2013-09-17 18:57 ` Thomas Gleixner
@ 2013-09-18 1:48 ` Xie XiuQi
0 siblings, 0 replies; 3+ messages in thread
From: Xie XiuQi @ 2013-09-18 1:48 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: John Stultz, Ingo Molnar, linux-kernel@vger.kernel.org
On 2013/9/18 2:57, Thomas Gleixner wrote:
> On Tue, 17 Sep 2013, Xie XiuQi wrote:
>
>> The functions clocksource_updatefreq_hz() and clocksource_updatefreq_khz()
>> do not exist, The proper ones are __clocksource_updatefreq_hz() and
>> __clocksource_updatefreq_khz().
>
> I'd rather rename the functions and the few call sites because the
> underscores are completely meaningless.
That's a good idea, thanks. I'll update this patch and send later.
>
> Thanks,
>
> tglx
>
>> Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
>> ---
>> kernel/time/clocksource.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
>> index 50a8736..d2f6ddc 100644
>> --- a/kernel/time/clocksource.c
>> +++ b/kernel/time/clocksource.c
>> @@ -714,7 +714,8 @@ static void clocksource_enqueue(struct clocksource *cs)
>> * This should only be called from the clocksource->enable() method.
>> *
>> * This *SHOULD NOT* be called directly! Please use the
>> - * clocksource_updatefreq_hz() or clocksource_updatefreq_khz helper functions.
>> + * __clocksource_updatefreq_hz() or __clocksource_updatefreq_khz helper
>> + * functions.
>> */
>> void __clocksource_updatefreq_scale(struct clocksource *cs, u32 scale, u32 freq)
>> {
>> --
>> 1.8.2.1
>>
>>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-18 1:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-17 10:40 [PATCH] clocksource: fix comment for __clocksource_updatefreq_scale Xie XiuQi
2013-09-17 18:57 ` Thomas Gleixner
2013-09-18 1:48 ` Xie XiuQi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox