From: Daniel Santos <danielfsantos@att.net>
To: David Howells <dhowells@redhat.com>
Cc: Daniel Santos <daniel.santos@pobox.com>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Michal Marek <mmarek@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
George Spelvin <linux@horizon.com>
Subject: Re: [PATCH 1/5] scripts: Add mkstrerror.sh
Date: Wed, 18 Sep 2013 17:27:03 -0500 [thread overview]
Message-ID: <523A28B7.10703@att.net> (raw)
In-Reply-To: <1352.1379505310@warthog.procyon.org.uk>
On 09/18/2013 06:55 AM, David Howells wrote:
> David Howells <dhowells@redhat.com> wrote:
>
>> (1) Why are you double-NUL'ing all your strings? (see the \0 in the strings)
> Ah... I see what you're doing. I missed the fact that you don't have a comma
> after each string.
Yeah, I was trying to format the code so that it's efficient and still
easy to read, but then there's no comma where we normally expect one.
It's the best middle ground solution I could come up with.
next prev parent reply other threads:[~2013-09-18 22:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 23:08 [PATCH 0/5] Preliminary: Add error names & descrptions to printks danielfsantos
2013-09-17 23:08 ` [PATCH 1/5] scripts: Add mkstrerror.sh danielfsantos
2013-09-18 11:38 ` David Howells
2013-09-18 11:55 ` David Howells
2013-09-18 22:27 ` Daniel Santos [this message]
2013-09-18 22:43 ` Daniel Santos
2013-09-19 22:35 ` Daniel Santos
2013-09-19 22:53 ` Daniel Santos
2013-09-17 23:08 ` [PATCH 2/5] lib: Add .config options for error strings in printks danielfsantos
2013-09-17 23:18 ` Daniel Santos
2013-09-17 23:08 ` [PATCH 3/5] Makefile: Generate error_strings.h danielfsantos
2013-09-17 23:08 ` [PATCH 4/5] lib: Add strerror and strerror_name functions danielfsantos
2013-09-17 23:08 ` [PATCH 5/5] lib: Add error string support to printks danielfsantos
2013-09-18 5:36 ` Joe Perches
2013-09-18 11:04 ` David Howells
2013-09-19 1:27 ` Daniel Santos
2013-09-20 1:07 ` Joe Perches
2013-09-20 5:21 ` Daniel Santos
2013-09-20 11:45 ` Joe Perches
2013-09-20 13:07 ` David Howells
2013-09-23 20:17 ` Daniel Santos
2013-09-23 19:40 ` Daniel Santos
2013-09-18 11:08 ` [PATCH 0/5] Preliminary: Add error names & descrptions " David Howells
2013-09-18 22:47 ` Daniel Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523A28B7.10703@att.net \
--to=danielfsantos@att.net \
--cc=akpm@linux-foundation.org \
--cc=daniel.santos@pobox.com \
--cc=dave.hansen@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=mmarek@suse.cz \
--cc=mtk.manpages@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox