* [PATCH 1/1] Fix address of second XOR engine in Kirkwood SoC DT
@ 2013-09-19 11:00 Quentin Armitage
2013-09-19 11:19 ` Sebastian Hesselbarth
2013-09-20 3:14 ` Jason Cooper
0 siblings, 2 replies; 3+ messages in thread
From: Quentin Armitage @ 2013-09-19 11:00 UTC (permalink / raw)
To: linux-kernel; +Cc: Jason Cooper
There appears to be an error in the second address of the second XOR
engine in the Kirkwood SoC device tree, which is specified as 0xd0b00
but should be 0x60b00.
For confirmation of address see
http://www.marvell.com/embedded-processors/kirkwood/assets/FS_88F6180_9x_6281_OpenSource.pdf table 581 page 658.
Also see definition of XOR1_HIGH_PHYS_BASE in
arch/arm/mach-kirkwood/include/mach/kirkwood.h
#define XOR1_HIGH_PHYS_BASE (KIRKWOOD_REGS_PHYS_BASE + 0x60B00)
Signed-off-by: Quentin Armitage <quentin@armitage.org.uk>
---
arch/arm/boot/dts/kirkwood.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/kirkwood.dtsi
b/arch/arm/boot/dts/kirkwood.dtsi
index cf7aeaf..63d4066 100644
--- a/arch/arm/boot/dts/kirkwood.dtsi
+++ b/arch/arm/boot/dts/kirkwood.dtsi
@@ -167,7 +167,7 @@
xor@60900 {
compatible = "marvell,orion-xor";
reg = <0x60900 0x100
- 0xd0B00 0x100>;
+ 0x60B00 0x100>;
status = "okay";
clocks = <&gate_clk 16>;
---
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] Fix address of second XOR engine in Kirkwood SoC DT
2013-09-19 11:00 [PATCH 1/1] Fix address of second XOR engine in Kirkwood SoC DT Quentin Armitage
@ 2013-09-19 11:19 ` Sebastian Hesselbarth
2013-09-20 3:14 ` Jason Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Hesselbarth @ 2013-09-19 11:19 UTC (permalink / raw)
To: Quentin Armitage, linux-kernel; +Cc: Jason Cooper
On 09/19/13 13:00, Quentin Armitage wrote:
> There appears to be an error in the second address of the second XOR
> engine in the Kirkwood SoC device tree, which is specified as 0xd0b00
> but should be 0x60b00.
>
> For confirmation of address see
> http://www.marvell.com/embedded-processors/kirkwood/assets/FS_88F6180_9x_6281_OpenSource.pdf table 581 page 658.
> Also see definition of XOR1_HIGH_PHYS_BASE in
> arch/arm/mach-kirkwood/include/mach/kirkwood.h
> #define XOR1_HIGH_PHYS_BASE (KIRKWOOD_REGS_PHYS_BASE + 0x60B00)
>
> Signed-off-by: Quentin Armitage <quentin@armitage.org.uk>
I double-checked the references, typo and fix are correct.
Reviewed-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
> arch/arm/boot/dts/kirkwood.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood.dtsi
> b/arch/arm/boot/dts/kirkwood.dtsi
> index cf7aeaf..63d4066 100644
> --- a/arch/arm/boot/dts/kirkwood.dtsi
> +++ b/arch/arm/boot/dts/kirkwood.dtsi
> @@ -167,7 +167,7 @@
> xor@60900 {
> compatible = "marvell,orion-xor";
> reg = <0x60900 0x100
> - 0xd0B00 0x100>;
> + 0x60B00 0x100>;
> status = "okay";
> clocks = <&gate_clk 16>;
>
> ---
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] Fix address of second XOR engine in Kirkwood SoC DT
2013-09-19 11:00 [PATCH 1/1] Fix address of second XOR engine in Kirkwood SoC DT Quentin Armitage
2013-09-19 11:19 ` Sebastian Hesselbarth
@ 2013-09-20 3:14 ` Jason Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Jason Cooper @ 2013-09-20 3:14 UTC (permalink / raw)
To: Quentin Armitage; +Cc: linux-kernel
On Thu, Sep 19, 2013 at 12:00:29PM +0100, Quentin Armitage wrote:
> There appears to be an error in the second address of the second XOR
> engine in the Kirkwood SoC device tree, which is specified as 0xd0b00
> but should be 0x60b00.
>
> For confirmation of address see
> http://www.marvell.com/embedded-processors/kirkwood/assets/FS_88F6180_9x_6281_OpenSource.pdf table 581 page 658.
> Also see definition of XOR1_HIGH_PHYS_BASE in
> arch/arm/mach-kirkwood/include/mach/kirkwood.h
> #define XOR1_HIGH_PHYS_BASE (KIRKWOOD_REGS_PHYS_BASE + 0x60B00)
>
> Signed-off-by: Quentin Armitage <quentin@armitage.org.uk>
>
> ---
> arch/arm/boot/dts/kirkwood.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to mvebu/fixes with Sebastian's Reviewed-by.
thx,
Jason.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-20 3:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-19 11:00 [PATCH 1/1] Fix address of second XOR engine in Kirkwood SoC DT Quentin Armitage
2013-09-19 11:19 ` Sebastian Hesselbarth
2013-09-20 3:14 ` Jason Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox