From: "H. Peter Anvin" <hpa@zytor.com>
To: Roy Franz <roy.franz@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
matt.fleming@intel.com, leif.lindholm@linaro.org,
msalter@redhat.com
Subject: Re: [PATCH V4 00/17] ARM EFI stub common code
Date: Fri, 20 Sep 2013 09:32:16 -0500 [thread overview]
Message-ID: <523C5C70.40908@zytor.com> (raw)
In-Reply-To: <1379391093-27948-1-git-send-email-roy.franz@linaro.org>
A general note:
In multiline comments like:
/* Relocate a kernel image, either compressed or uncompressed.
* In the ARM64 case, all kernel images are currently
* uncompressed, and as such when we relocate it we need to
* allocate additional space for the BSS segment. Any low
* memory that this function should avoid needs to be
* unavailable in the EFI memory map, as if the preferred
* address is not available the lowest available address will
* be used.
*/
Please have a blank line at the beginning:
/*
* Relocate a kernel image, either compressed or uncompressed.
* In the ARM64 case, all kernel images are currently
* uncompressed, and as such when we relocate it we need to
* allocate additional space for the BSS segment. Any low
* memory that this function should avoid needs to be
* unavailable in the EFI memory map, as if the preferred
* address is not available the lowest available address will
* be used.
*/
Also, if this a comment at the head of a function, have a blank line
before the comment.
-hpa
prev parent reply other threads:[~2013-09-20 14:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 4:11 [PATCH V4 00/17] ARM EFI stub common code Roy Franz
2013-09-17 4:11 ` [PATCH 01/17] EFI stub documentation updates Roy Franz
2013-09-17 4:11 ` [PATCH 02/17] Add proper definitions for some EFI function pointers Roy Franz
2013-09-17 4:11 ` [PATCH 03/17] Move common EFI stub code from x86 arch code to common location Roy Franz
2013-09-17 4:11 ` [PATCH 04/17] Add system table pointer argument to shared functions Roy Franz
2013-09-17 4:11 ` [PATCH 05/17] Rename memory allocation/free functions Roy Franz
2013-09-17 4:11 ` [PATCH 06/17] Enforce minimum alignment of 1 page on allocations Roy Franz
2013-09-17 4:11 ` [PATCH 07/17] Move relocate_kernel() to shared file Roy Franz
2013-09-17 4:11 ` [PATCH 08/17] Generalize relocate_kernel() for use by other architectures Roy Franz
2013-09-18 12:12 ` Matt Fleming
2013-09-18 16:31 ` Roy Franz
2013-09-17 4:11 ` [PATCH 09/17] Move unicode to ASCII conversion to shared function Roy Franz
2013-09-19 3:44 ` Adam Borowski
2013-09-19 3:46 ` H. Peter Anvin
2013-09-19 4:48 ` Roy Franz
2013-09-19 23:02 ` Adam Borowski
2013-09-20 9:30 ` Matt Fleming
2013-09-20 9:27 ` Matt Fleming
2013-09-20 15:00 ` H. Peter Anvin
2013-09-21 21:31 ` Roy Franz
2013-09-17 4:11 ` [PATCH 10/17] Rename __get_map() to efi_get_memory_map() Roy Franz
2013-09-17 4:11 ` [PATCH 11/17] generalize efi_get_memory_map() Roy Franz
2013-09-17 4:11 ` [PATCH 12/17] use efi_get_memory_map() to get final map for x86 Roy Franz
2013-09-17 4:11 ` [PATCH 13/17] Allow efi_free() to be called with size of 0, and do nothing in that case Roy Franz
2013-09-17 4:11 ` [PATCH 14/17] Generalize handle_ramdisks() and rename to handle_cmdline_files() Roy Franz
2013-09-17 4:11 ` [PATCH 15/17] Renames in handle_cmdline_files() to complete generalization Roy Franz
2013-09-17 4:11 ` [PATCH 16/17] Fix types in EFI calls to match EFI function definitions Roy Franz
2013-09-17 4:11 ` [PATCH 17/17] resolve warnings found on ARM compile Roy Franz
2013-09-18 13:21 ` [PATCH V4 00/17] ARM EFI stub common code Matt Fleming
2013-09-20 14:32 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523C5C70.40908@zytor.com \
--to=hpa@zytor.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=msalter@redhat.com \
--cc=roy.franz@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox