From: Jonathan Cameron <jic23@kernel.org>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Thomas Meyer <thomas@m3y3r.de>,
jic23@cam.ac.uk, grant.likely@linaro.org,
rob.herring@calxeda.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/10] iio: at91_adc: Cocci spatch "noderef"
Date: Fri, 20 Sep 2013 19:42:38 +0100 [thread overview]
Message-ID: <523C971E.5090809@kernel.org> (raw)
In-Reply-To: <523C95B0.6070906@kernel.org>
On 09/20/13 19:36, Jonathan Cameron wrote:
> On 09/20/13 08:26, Nicolas Ferre wrote:
>> On 19/09/2013 23:42, Thomas Meyer :
>>> sizeof when applied to a pointer typed expression gives the size of the
>>> pointer.
>>> Found by coccinelle spatch "misc/noderef.cocci"
>>>
>>> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
>>
>> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Applied to the fixes-togreg branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
Actually, change of plan. Applied to the togreg branch of that
tree. Whilst technically more correct to have it as you say,
we are dealing with the size of a struct iio_trig ** vs
a struct iio_trig * so it isn't actually a bug, just a
less than ideal bit of code ;)
It was so obviously a fix I didn't initially check if it
was a 'real' bug or not. oops.
Jonathan
>
> Thanks,
>>
>>> ---
>>>
>>> diff -u -p a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
>>> --- a/drivers/iio/adc/at91_adc.c
>>> +++ b/drivers/iio/adc/at91_adc.c
>>> @@ -279,7 +279,7 @@ static int at91_adc_trigger_init(struct
>>> int i, ret;
>>>
>>> st->trig = devm_kzalloc(&idev->dev,
>>> - st->trigger_number * sizeof(st->trig),
>>> + st->trigger_number * sizeof(*st->trig),
>>> GFP_KERNEL);
>>>
>>> if (st->trig == NULL) {
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>
>>
>>
next prev parent reply other threads:[~2013-09-20 17:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 21:45 [PATCH 0/10] Cocci spatch "noderef" - v3.11-7547-g44598f9 Thomas Meyer
2013-09-19 21:42 ` [PATCH 3/10] iio: at91_adc: Cocci spatch "noderef" Thomas Meyer
2013-09-20 7:26 ` Nicolas Ferre
2013-09-20 18:36 ` Jonathan Cameron
2013-09-20 18:42 ` Jonathan Cameron [this message]
2013-09-23 12:16 ` Nicolas Ferre
2013-09-19 21:42 ` [PATCH 2/10] xtensa: " Thomas Meyer
2013-09-19 22:10 ` Joe Perches
2013-09-19 21:45 ` [PATCH 4/10] [SCSI] csiostor: " Thomas Meyer
2013-09-19 21:45 ` [PATCH 6/10] staging: octeon-usb: " Thomas Meyer
2013-09-19 21:45 ` [PATCH 1/10] MIPS: BCM47XX: " Thomas Meyer
2013-09-19 21:08 ` Hauke Mehrtens
2013-09-19 21:45 ` [PATCH 7/10] staging: r8188eu: Add files for new drive: " Thomas Meyer
2013-09-20 10:43 ` Dan Carpenter
2013-09-19 21:45 ` [PATCH 9/10] staging: r8188eu: " Thomas Meyer
2013-09-20 10:44 ` Dan Carpenter
2013-09-19 21:45 ` [PATCH 5/10] staging: lustre: " Thomas Meyer
2013-09-19 21:45 ` [PATCH 8/10] staging: r8188eu: Add files for new drive: " Thomas Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523C971E.5090809@kernel.org \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=rob.herring@calxeda.com \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).