From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: Larry.Finger@lwfinger.net, chaoming_li@realsil.com.cn,
joe@perches.com, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH V2] wireless: rtlwifi: Replace variable with a brake
Date: Sun, 22 Sep 2013 23:56:38 +0400 [thread overview]
Message-ID: <523F4B76.80507@cogentembedded.com> (raw)
In-Reply-To: <1379879410-22787-1-git-send-email-peter.senna@gmail.com>
Hello.
On 09/22/2013 11:50 PM, Peter Senna Tschudin wrote:
You have a typo in the subject -- "brake" is a device to stop a vehicle. :-)
> This patch removes the variable continual, and change the while loop
> to break when efuse_data == 0xFF.
> Tested by compilation only.
> CC: Joe Perches <joe@perches.com>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> Changes from V1:
> - Fix the indetation
> - Remove remaining } from removed else
> Please ignore the patch:
> [PATCH 12/19] wireless: Change variable type to bool
> And apply this one instead.
> The variable continual was declared as int, but was used as bool. I
> sent previous patch changing the variable type to bool, but Joe Perches
> proposed that removing the variable and adding a brake would be better.
> drivers/net/wireless/rtlwifi/efuse.c | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
> diff --git a/drivers/net/wireless/rtlwifi/efuse.c b/drivers/net/wireless/rtlwifi/efuse.c
> index 838a1ed..2aedd9f 100644
> --- a/drivers/net/wireless/rtlwifi/efuse.c
> +++ b/drivers/net/wireless/rtlwifi/efuse.c
> @@ -1203,20 +1203,18 @@ static void efuse_power_switch(struct ieee80211_hw *hw, u8 write, u8 pwrstate)
>
> static u16 efuse_get_current_size(struct ieee80211_hw *hw)
> {
> - int continual = true;
> u16 efuse_addr = 0;
> u8 hworden;
> u8 efuse_data, word_cnts;
>
> - while (continual && efuse_one_byte_read(hw, efuse_addr, &efuse_data)
> - && (efuse_addr < EFUSE_MAX_SIZE)) {
> - if (efuse_data != 0xFF) {
> - hworden = efuse_data & 0x0F;
> - word_cnts = efuse_calculate_word_cnts(hworden);
> - efuse_addr = efuse_addr + (word_cnts * 2) + 1;
> - } else {
> - continual = false;
> - }
> + while (efuse_one_byte_read(hw, efuse_addr, &efuse_data) &&
> + (efuse_addr < EFUSE_MAX_SIZE)) {
Start this line under efuse_one_byte_read, please. Also, parens are not
needed.
WBR, Sergei
next prev parent reply other threads:[~2013-09-22 19:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-22 19:50 [PATCH V2] wireless: rtlwifi: Replace variable with a brake Peter Senna Tschudin
2013-09-22 19:56 ` Sergei Shtylyov [this message]
2013-09-22 20:24 ` Peter Senna Tschudin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523F4B76.80507@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=peter.senna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox