From: Roland Dreier <roland@topspin.com>
To: Andrew Morton <akpm@osdl.org>
Cc: jstubbs@work-at.co.jp, linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: Consistent lock up on >=2.6.8
Date: Mon, 04 Oct 2004 21:05:27 -0700 [thread overview]
Message-ID: <523c0tvmgo.fsf@topspin.com> (raw)
In-Reply-To: <20041004205136.49317eb7.akpm@osdl.org> (Andrew Morton's message of "Mon, 4 Oct 2004 20:51:36 -0700")
Andrew> Excellent point. We don't appear to have a function which
Andrew> does that.
Excellent point right back at you... I didn't notice that the ip_vs
work was rescheduling itself.
Andrew> How does this look?
+void cancel_rearming_delayed_workqueue(struct workqueue_struct *wq,
+ struct work_struct *work)
+{
+ while (!cancel_delayed_work(work))
+ flush_workqueue(wq);
+}
Seems like it should work as long as (as you note) the work _always_
reschedules itself, and no one else ever tries to schedule the work.
Maybe it's easier to say that users of rearming delayed work just have
to have a "stop" flag somewhere? I have a feeling that an API for
such a particular situation is just an invitation for foot-shooting.
- Roland
next prev parent reply other threads:[~2004-10-05 4:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-04 7:11 PROBLEM: Consistent lock up on >=2.6.8 Jason Stubbs
2004-10-04 8:35 ` Andrew Morton
2004-10-04 10:31 ` Jason Stubbs
2004-10-04 19:05 ` Andrew Morton
2004-10-05 1:53 ` Jason Stubbs
2004-10-05 1:58 ` Andrew Morton
2004-10-05 4:17 ` Jason Stubbs
2004-10-29 15:08 ` RESEND: Consistent lock up 2.6.8-1.521 (and 2.6.8.1 w/ high-res-timers/skas/sysemu) Andrew A.
2004-10-29 15:22 ` Andrew A.
2004-10-29 15:23 ` Andrew A.
2004-10-05 2:03 ` PROBLEM: Consistent lock up on >=2.6.8 Roland Dreier
2004-10-05 3:51 ` Andrew Morton
2004-10-05 4:05 ` Roland Dreier [this message]
2004-11-25 1:03 ` Jason Stubbs
-- strict thread matches above, loose matches on Subject: below --
2004-12-06 8:30 Chris Caputo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523c0tvmgo.fsf@topspin.com \
--to=roland@topspin.com \
--cc=akpm@osdl.org \
--cc=jstubbs@work-at.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox