From: Li Zefan <lizefan@huawei.com>
To: David Woodhouse <David.Woodhouse@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>
Subject: [PATCH] jffs2: fix unbalanced locking
Date: Mon, 23 Sep 2013 16:52:30 +0800 [thread overview]
Message-ID: <5240014E.1080804@huawei.com> (raw)
In the failure path in jffs2_do_crccheck_inode() the lock isn't released
before returning.
This probably won't cause real bug, because the structure that contains
the lock is freed in this case.
Signed-off-by: Li Zefan <lizefan@huawei.com>
---
fs/jffs2/readinode.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/jffs2/readinode.c b/fs/jffs2/readinode.c
index ae81b01..55cf63d 100644
--- a/fs/jffs2/readinode.c
+++ b/fs/jffs2/readinode.c
@@ -1425,7 +1425,8 @@ int jffs2_do_crccheck_inode(struct jffs2_sb_info *c, struct jffs2_inode_cache *i
jffs2_do_clear_inode(c, f);
}
jffs2_xattr_do_crccheck_inode(c, ic);
- kfree (f);
+ mutex_unlock(&f->sem);
+ kfree(f);
return ret;
}
--
1.8.0.2
reply other threads:[~2013-09-23 8:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5240014E.1080804@huawei.com \
--to=lizefan@huawei.com \
--cc=David.Woodhouse@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox