Re: [tpmdd-devel] [PATCH 00/13] TPM cleanup

[Joel Schopp <jschopp@linux.vnet.ibm.com>]

> Jason Gunthorpe (13):
>   tpm: ibmvtpm: Use %zd formatting for size_t format arguments
>   tpm atmel: Call request_region with the correct base
>   tpm: xen-tpmfront: Fix default durations
>   tpm: Store devname in the tpm_chip
>   tpm: Use container_of to locate the tpm_chip in tpm_open
>   tpm: Remove redundant dev_set_drvdata
>   tpm: Remove tpm_show_caps_1_2
>   tpm: Pull everything related to /dev/tpmX into tpm-dev.c
>   tpm: Pull everything related to sysfs into tpm-sysfs.c
>   tpm: Create a tpm_class_ops structure and use it in the drivers
>   tpm: Use the ops structure instead of a copy in tpm_vendor_specific
>   tpm: st33: Remove chip->data_buffer access from this driver
>   tpm: Make tpm-dev allocate a per-file structure
> 
>  drivers/char/tpm/Makefile           |   2 +-
>  drivers/char/tpm/tpm-dev.c          | 213 +++++++++++++++
>  drivers/char/tpm/tpm-sysfs.c        | 318 ++++++++++++++++++++++
>  drivers/char/tpm/tpm.c              | 524 +++---------------------------------
>  drivers/char/tpm/tpm.h              |  86 +++---
>  drivers/char/tpm/tpm_atmel.c        |  30 +--
>  drivers/char/tpm/tpm_i2c_atmel.c    |  42 +--
>  drivers/char/tpm/tpm_i2c_infineon.c |  44 +--
>  drivers/char/tpm/tpm_i2c_nuvoton.c  |  42 +--
>  drivers/char/tpm/tpm_i2c_stm_st33.c |  51 +---
>  drivers/char/tpm/tpm_ibmvtpm.c      |  44 +--
>  drivers/char/tpm/tpm_infineon.c     |  28 +-
>  drivers/char/tpm/tpm_nsc.c          |  28 +-
>  drivers/char/tpm/tpm_spi_stm_st33.c |  50 +---
>  drivers/char/tpm/tpm_tis.c          |  43 +--
>  drivers/char/tpm/xen-tpmfront.c     |  57 +---
>  include/linux/tpm.h                 |  15 ++
>  17 files changed, 638 insertions(+), 979 deletions(-)
>  create mode 100644 drivers/char/tpm/tpm-dev.c
>  create mode 100644 drivers/char/tpm/tpm-sysfs.c
> 

For what it's worth I have nothing to say except the cleanups look sane
to me.
Reviewed-by: Joel Schopp <jschopp@linux.vnet.ibm.com>