Re: [PATCH] kernel/groups.c: consider about NULL for 'group_info' in all related extern functions

Tejun Heo
2013-09-26T13:15:52Z

Hello, Chen.

On Thu, Sep 26, 2013 at 02:30:31PM +0800, Chen Gang wrote:
> > Oh, not cause issue, the reason is "'groups' exports extern variable
> > 'init_groups', when start process, default 'cred' will set it to be
> > sure of groups always be initialized".
> >
> > Hmm... but after all, I still think this file need be improved: "remove
> > the group_info checking in groups_search()", please help check, thanks.

Given the track record upto this point and how marginal the benefit of
the suggested change is, I'd rather not. It's quite possible that we
had specific issue where that extra conditional is necessary and I
don't feel comfortable trusting your evaluation and analysis on the
subject at the moment, so the benefit / risk ratio seems way off from
my pov.

> > If groups_alloc() fails, the caller must not call any related API again
> > with the related invalid 'group_info'.
> >
> >
> > Signed-off-by: Chen Gang <gang.chen@asianux.com>

Nacked-by: Tejun Heo <tj@kernel.org>

Thanks.

--
tejun