From: Shuah Khan <shuah.kh@samsung.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: alex.williamson@redhat.com, Varun.Sethi@freescale.com,
udknight@gmail.com, aik@ozlabs.ru, rostedt@goodmis.org,
fweisbec@gmail.com, mingo@redhat.com,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
shuahkhan@gmail.com, Shuah Khan <shuah.kh@samsung.com>
Subject: Re: [PATCH 1/2] iommu: Add iommu_fault class event to iommu trace
Date: Tue, 24 Sep 2013 06:39:49 -0600 [thread overview]
Message-ID: <52418815.20701@samsung.com> (raw)
In-Reply-To: <20130924104855.GB4532@8bytes.org>
On 09/24/2013 04:48 AM, Joerg Roedel wrote:
> On Fri, Aug 16, 2013 at 11:20:16AM -0600, Shuah Khan wrote:
>> +DEFINE_EVENT(iommu_fault, report_fault,
>> +
>> + TP_PROTO(struct device *dev, unsigned long iova, int flags),
>> +
>> + TP_ARGS(dev, iova, flags)
>> +);
>
> I am not entirely happy with the naming. It is better to name the class
> iommu_error and the page-fault event io_page_fault. This makes it more
> clear what kind of fault it is.
>
>
> Joerg
>
>
Joerg,
Yes, iommu_error and io_page_fault sounds better. I will rename and send
the updated patch.
-- Shuah
--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658
next prev parent reply other threads:[~2013-09-24 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 17:20 [PATCH 0/2] iommu: Add iommu_fault class event to iommu trace Shuah Khan
2013-08-16 17:20 ` [PATCH 1/2] " Shuah Khan
2013-09-24 10:48 ` Joerg Roedel
2013-09-24 12:39 ` Shuah Khan [this message]
2013-08-16 17:20 ` [PATCH 2/2] iommu: Change iommu driver to call report_fault trace event Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52418815.20701@samsung.com \
--to=shuah.kh@samsung.com \
--cc=Varun.Sethi@freescale.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=fweisbec@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=shuahkhan@gmail.com \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox