From: Stephen Warren <swarren@wwwdotorg.org>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Mike Turquette <mturquette@linaro.org>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Thierry Reding <thierry.reding@avionic-design.de>,
Joseph Lo <josephl@nvidia.com>,
Paul Walmsley <pwalmsley@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 10/12] clk: tegra: move fixed clocks to common file
Date: Tue, 24 Sep 2013 10:47:14 -0600 [thread overview]
Message-ID: <5241C212.9030601@wwwdotorg.org> (raw)
In-Reply-To: <20130924083231.GK30013@tbergstrom-lnx.Nvidia.com>
On 09/24/2013 02:32 AM, Peter De Schrijver wrote:
> On Mon, Sep 23, 2013 at 08:34:48PM +0200, Stephen Warren wrote:
>> On 09/18/2013 08:41 AM, Peter De Schrijver wrote:
>>> Introduce a new file for fixed clocks common between several Tegra
>>> SoCs and move Tegra114 to this new infrastructure.
>>
>>> diff --git a/drivers/clk/tegra/clk-tegra-fixed.c b/drivers/clk/tegra/clk-tegra-fixed.c
>>
>>> +void __init tegra_fixed_clk_init(struct tegra_clk *tegra_clks)
>>
>>> + /* clk_m_div2 */
>>> + dt_clk = tegra_lookup_dt_id(tegra_clk_clk_m_div2, tegra_clks);
>>> + if (dt_clk) {
>>> + clk = clk_register_fixed_factor(NULL, "clk_m_div2", "clk_m",
>>> + CLK_SET_RATE_PARENT, 1, 2);
>>> + clk_register_clkdev(clk, "clk_m_div2", NULL);
>>> + *dt_clk = clk;
>>> + }
>>
>> I guess "fixed" means "fixed at run-time", not "identical rate in all
>> systems"? Since this is the crystal rate, it can vary between boards,
>> but I supposed if "fixed" means "fixed at run-time", considering this as
>> a fixed clock is fine.
>>
>
> Fixed means "fixed at run-time" indeed. Although clk_32k is 32768Hz on all
> boards as well.
>
>> But, isn't clk_m also a fixed clock then? I would expect one or two more
>
> I guess the code from clk-tegra-osc.c could be moved here if you think that's
> better?
It's probably not a big deal either way, but since both files are quite
tiny, and closely related, merging them seems reasonable.
>> clocks in this file. What about clk_s, or is that known as clk_32k here?
>
> I don't think we ever had clk_s in upstream?
Looking at the Tegra114 TRM at least, it seems like it's just another
name for clk_32k. But, if there's more to it than that, I guess there's
no need to add it as part of this series if we haven't had a need for it
yet.
next prev parent reply other threads:[~2013-09-24 16:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 14:40 [PATCH 00/12] Introduce common infra for tegra clocks Peter De Schrijver
2013-09-18 14:40 ` [PATCH 01/12] clk: tegra: simplify periph clock data Peter De Schrijver
2013-09-23 17:29 ` Stephen Warren
2013-09-18 14:40 ` [PATCH 02/12] clk: tegra: periph_clk_enb_refcnt as common infra Peter De Schrijver
2013-09-18 14:40 ` [PATCH 03/12] clk: tegra: Add TEGRA_PERIPH_NO_DIV flag Peter De Schrijver
2013-09-23 17:52 ` Stephen Warren
2013-09-18 14:40 ` [PATCH 04/12] clk: tegra: move some PLLC and PLLXC init to clk-pll.c Peter De Schrijver
2013-09-18 14:40 ` [PATCH 05/12] clk: tegra: add header for common tegra clock IDs Peter De Schrijver
2013-09-23 18:05 ` Stephen Warren
2013-09-24 8:08 ` Peter De Schrijver
2013-09-18 14:40 ` [PATCH 06/12] clk: tegra: add common infra for DT clocks Peter De Schrijver
2013-09-23 18:16 ` Stephen Warren
2013-09-18 14:40 ` [PATCH 07/12] clk: tegra: move audio clk to common file Peter De Schrijver
2013-09-23 18:22 ` Stephen Warren
2013-09-18 14:41 ` [PATCH 08/12] clk: tegra: move periph clocks " Peter De Schrijver
2013-09-23 18:31 ` Stephen Warren
2013-09-24 8:20 ` Peter De Schrijver
2013-09-24 16:44 ` Stephen Warren
2013-09-18 14:41 ` [PATCH 09/12] clk: tegra: move PMC " Peter De Schrijver
2013-09-18 14:41 ` [PATCH 10/12] clk: tegra: move fixed " Peter De Schrijver
2013-09-23 18:34 ` Stephen Warren
2013-09-24 8:32 ` Peter De Schrijver
2013-09-24 16:47 ` Stephen Warren [this message]
2013-09-18 14:41 ` [PATCH 11/12] clk: tegra: introduce common tegra_osc_clk_init Peter De Schrijver
2013-09-18 14:41 ` [PATCH 12/12] clk: tegra: introduce common gen4 super clock Peter De Schrijver
2013-09-23 18:38 ` Stephen Warren
2013-09-18 14:48 ` [PATCH 00/12] Introduce common infra for tegra clocks Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5241C212.9030601@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=pwalmsley@nvidia.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox