From: "H. Peter Anvin" <hpa@zytor.com>
To: mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
holt@sgi.com, rmk+kernel@arm.linux.org.uk,
stable@vger.kernel.org, tglx@linutronix.de, gxt@mprc.pku.edu.cn,
vlee@twitter.com, msharbiani@twitter.com
Cc: tip-bot for Masoud Sharbiani <tipbot@zytor.com>,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86/reboot: Add quirk to make Dell C6100 use reboot=pci automatically
Date: Tue, 24 Sep 2013 15:55:24 -0700 [thread overview]
Message-ID: <5242185C.6070204@zytor.com> (raw)
In-Reply-To: <tip-4f0acd31c31f03ba42494c8baf6c0465150e2621@git.kernel.org>
On 09/23/2013 06:37 AM, tip-bot for Masoud Sharbiani wrote:
>
> diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
> index 563ed91..5f4ad27 100644
> --- a/arch/x86/kernel/reboot.c
> +++ b/arch/x86/kernel/reboot.c
> @@ -358,6 +358,22 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "Precision M6600"),
> },
> },
> + { /* Handle problems with rebooting on the Dell PowerEdge C6100. */
> + .callback = set_pci_reboot,
> + .ident = "Dell PowerEdge C6100",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "C6100"),
> + },
> + },
> + { /* Some C6100 machines were shipped with vendor being 'Dell'. */
> + .callback = set_pci_reboot,
> + .ident = "Dell PowerEdge C6100",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "C6100"),
> + },
Aren't these substring matches anyway? If so, the first entry is redundant.
-hpa
prev parent reply other threads:[~2013-09-24 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 22:59 [PATCH] x86: Add quirk to make Dell C6100 use reboot=pci Vinson Lee
2013-09-23 13:37 ` [tip:x86/urgent] x86/reboot: Add quirk to make Dell C6100 use reboot=pci automatically tip-bot for Masoud Sharbiani
2013-09-24 22:55 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5242185C.6070204@zytor.com \
--to=hpa@zytor.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=msharbiani@twitter.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tipbot@zytor.com \
--cc=vlee@twitter.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox