From: Chris Metcalf <cmetcalf@tilera.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tile: include: asm: use 'long long' instead of 'u64' for atomic64_t and its related functions
Date: Wed, 25 Sep 2013 15:26:46 -0400 [thread overview]
Message-ID: <524338F6.2090508@tilera.com> (raw)
In-Reply-To: <52426310.4020204@asianux.com>
On 9/25/2013 12:14 AM, Chen Gang wrote:
> atomic* value is signed value, and atomic* functions need also process
> signed value (parameter value, and return value), so use 'long long'
> instead of 'u64'.
>
> After replacement, it will also fix a bug for atomic64_add_negative():
> "u64 is never less than 0".
>
> The modifications are:
>
> in vim, use "1,% s/\<u64\>/long long/g" command.
> remove redundant '__aligned(8)' and a type case '(u64 *)'.
> be sure of 80 (and macro '\') columns limitation after replacement.
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/tile/include/asm/atomic.h | 5 +++--
> arch/tile/include/asm/atomic_32.h | 27 +++++++++++++++------------
> arch/tile/include/asm/cmpxchg.h | 28 +++++++++++++++++-----------
> arch/tile/lib/atomic_32.c | 8 ++++----
> 4 files changed, 39 insertions(+), 29 deletions(-)
Thanks! Taken into the tile tree for 3.12.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
next prev parent reply other threads:[~2013-09-25 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 4:14 [PATCH] tile: include: asm: use 'long long' instead of 'u64' for atomic64_t and its related functions Chen Gang
2013-09-25 19:26 ` Chris Metcalf [this message]
2013-09-26 0:50 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524338F6.2090508@tilera.com \
--to=cmetcalf@tilera.com \
--cc=gang.chen@asianux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox