From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] clocksource: of: respect device tree node status
Date: Thu, 26 Sep 2013 02:10:22 +0200 [thread overview]
Message-ID: <52437B6E.1030402@linaro.org> (raw)
In-Reply-To: <52430278.3040604@gmail.com>
On 09/25/2013 05:34 PM, Sebastian Hesselbarth wrote:
> On 09/25/2013 05:29 PM, Daniel Lezcano wrote:
>> On 09/19/2013 12:47 PM, Sebastian Hesselbarth wrote:
>>> Clocksource devices provided by DT can be disabled (status != "okay").
>>> Instead of registering clocksource drivers for disabled nodes, respect
>>> the device's status by skiping disabled nodes.
>>>
>>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>>
>> Shall it be applied as a 3.12 fix ?
>
> Daniel,
>
> difficult to say. Although I am not aware of any mainline mach
> depends on it, I consider this a fix. So, if there are no objections
> please apply for 3.12.
Ok, applied to my tree.
Thanks
-- Daniel
>>> ---
>>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>> Cc: linux-kernel@vger.kernel.org
>>> ---
>>> drivers/clocksource/clksrc-of.c | 3 +++
>>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/clocksource/clksrc-of.c
>>> b/drivers/clocksource/clksrc-of.c
>>> index 37f5325..b9ddd9e 100644
>>> --- a/drivers/clocksource/clksrc-of.c
>>> +++ b/drivers/clocksource/clksrc-of.c
>>> @@ -30,6 +30,9 @@ void __init clocksource_of_init(void)
>>> clocksource_of_init_fn init_func;
>>> for_each_matching_node_and_match(np, __clksrc_of_table, &match) {
>>> + if (!of_device_is_available(np))
>>> + continue;
>>> +
>>> init_func = match->data;
>>> init_func(np);
>>> }
>>
>>
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2013-09-26 0:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 10:47 [PATCH RESEND] clocksource: of: respect device tree node status Sebastian Hesselbarth
2013-09-25 15:29 ` Daniel Lezcano
2013-09-25 15:34 ` Sebastian Hesselbarth
2013-09-26 0:10 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52437B6E.1030402@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox