Re: [PATCH] tile: include: asm: use 'long long' instead of 'u64' for atomic64_t and its related functions

[Chen Gang <gang.chen@asianux.com>]

On 09/26/2013 03:26 AM, Chris Metcalf wrote:
> On 9/25/2013 12:14 AM, Chen Gang wrote:
>> atomic* value is signed value, and atomic* functions need also process
>> signed value (parameter value, and return value), so use 'long long'
>> instead of 'u64'.
>>
>> After replacement, it will also fix a bug for atomic64_add_negative():
>> "u64 is never less than 0".
>>
>> The modifications are:
>>
>>   in vim, use "1,% s/\<u64\>/long long/g" command.
>>   remove redundant '__aligned(8)' and a type case '(u64 *)'.
>>   be sure of 80 (and macro '\') columns limitation after replacement.
>>
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> ---
>>  arch/tile/include/asm/atomic.h    |    5 +++--
>>  arch/tile/include/asm/atomic_32.h |   27 +++++++++++++++------------
>>  arch/tile/include/asm/cmpxchg.h   |   28 +++++++++++++++++-----------
>>  arch/tile/lib/atomic_32.c         |    8 ++++----
>>  4 files changed, 39 insertions(+), 29 deletions(-)
> 
> Thanks!  Taken into the tile tree for 3.12.
> 

Thank you too.

-- 
Chen Gang