From: Richard Genoud <richard.genoud@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: dedekind1@gmail.com, dwmw2@infradead.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] UBI: Call scan_all() with correct offset in error case
Date: Thu, 26 Sep 2013 09:22:11 +0200 [thread overview]
Message-ID: <5243E0A3.1060900@gmail.com> (raw)
In-Reply-To: <1380141125-11063-2-git-send-email-richard@nod.at>
On 25/09/2013 22:32, Richard Weinberger wrote:
> If we find an invalid fastmap we have to scan from the very beginning.
> Otherwise we leak the first 64 PEBs.
>
> Reported-by: Richard Genoud <richard.genoud@gmail.com>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> drivers/mtd/ubi/attach.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/ubi/attach.c b/drivers/mtd/ubi/attach.c
> index c071d41..03b32b0 100644
> --- a/drivers/mtd/ubi/attach.c
> +++ b/drivers/mtd/ubi/attach.c
> @@ -1417,9 +1417,11 @@ int ubi_attach(struct ubi_device *ubi, int force_scan)
> ai = alloc_ai("ubi_aeb_slab_cache2");
> if (!ai)
> return -ENOMEM;
> - }
>
> - err = scan_all(ubi, ai, UBI_FM_MAX_START);
> + err = scan_all(ubi, ai, 0);
> + } else {
> + err = scan_all(ubi, ai, UBI_FM_MAX_START);
> + }
> }
> }
> #else
>
Works great, the assert is not triggered anymore.
Tested-by: Richard Genoud <richard.genoud@gmail.com>
next prev parent reply other threads:[~2013-09-26 7:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 20:32 [PATCH 1/2] UBI: Fix error path in scan_pool() Richard Weinberger
2013-09-25 20:32 ` [PATCH 2/2] UBI: Call scan_all() with correct offset in error case Richard Weinberger
2013-09-26 7:22 ` Richard Genoud [this message]
2013-09-26 7:20 ` [PATCH 1/2] UBI: Fix error path in scan_pool() Richard Genoud
2013-09-26 7:24 ` Richard Weinberger
2013-09-26 7:33 ` Richard Genoud
2013-09-26 9:25 ` Richard Genoud
2013-09-26 9:59 ` Richard Weinberger
2013-09-27 11:01 ` Richard Weinberger
2013-09-27 11:12 ` Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5243E0A3.1060900@gmail.com \
--to=richard.genoud@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox