From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756406Ab3IZIaL (ORCPT ); Thu, 26 Sep 2013 04:30:11 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:45303 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756388Ab3IZIaH (ORCPT ); Thu, 26 Sep 2013 04:30:07 -0400 Message-ID: <5243F08B.4090907@linaro.org> Date: Thu, 26 Sep 2013 10:30:03 +0200 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Viresh Kumar CC: "Rafael J. Wysocki" , Lists linaro-kernel , Patch Tracking , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List Subject: Re: [PATCH 16/21] cpuidle: avoid unnecessary kzalloc/free of struct cpuidle_device_kobj References: <52435FE2.20805@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/26/2013 08:05 AM, Viresh Kumar wrote: > On 26 September 2013 03:42, Daniel Lezcano wrote: >> On 09/22/2013 03:21 AM, Viresh Kumar wrote: >>> We always need to allocate struct cpuidle_device_kobj for all CPUs and so there >>> is no real need to have a pointer to it inside struct cpuidle_device. >>> >>> This patch makes a object instance of struct cpuidle_device_kobj inside struct >>> cpuidle_device instead of a pointer. >>> >>> Signed-off-by: Viresh Kumar >> >> nack, it was made in purpose for kobject_init_and_add. >> >> see commit 728ce22b696f9f1404a74d7b2279a65933553a1b > > Ahh.. sorry for missing that one :( > > Now that I understand why it was introduced, I am thinking if > we can make hotplug path a bit fast? By not freeing sysfs stuff > and only hiding it for time being? And so we wouldn't be required > to do unnecessary initialisations while coming back? > > Would that be worth it? Yes if it possible. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog