From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752262AbbE0N2j (ORCPT ); Wed, 27 May 2015 09:28:39 -0400 Received: from mx3-phx2.redhat.com ([209.132.183.24]:35622 "EHLO mx3-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751746AbbE0N2i (ORCPT ); Wed, 27 May 2015 09:28:38 -0400 Date: Wed, 27 May 2015 09:28:36 -0400 (EDT) From: Frediano Ziglio To: Josh Boyer Cc: spice-devel@lists.freedesktop.org, Dave Airlie , DRI mailing list , Dave Airlie , "Linux-Kernel@Vger. Kernel. Org" Message-ID: <52443504.5205248.1432733316214.JavaMail.zimbra@redhat.com> In-Reply-To: References: <1432721046-4418-1-git-send-email-fziglio@redhat.com> Subject: Re: [PATCH 00/11] Miscellaneous stability patches MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.36.7.206] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF38 (Linux)/8.0.6_GA_5922) Thread-Topic: Miscellaneous stability patches Thread-Index: yILaBkG5yC4CWWOIXE7Mwx00ogXfIQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > On Wed, May 27, 2015 at 8:47 AM, Josh Boyer > wrote: > > On Wed, May 27, 2015 at 6:03 AM, Frediano Ziglio > > wrote: > >> This set of patches mainly contains fix for some memory issues > >> using quite aggressively surfaces and other minor problems like > >> images going black after a while. > >> > >> Frediano Ziglio (11): > >> Do not cause spice-server to clean our objects > >> Do not leak memory if qxl_release_list_add fails > >> Fix print statement not using uninitialized variable > >> Avoid double free on error > >> Handle all errors in qxl_surface_evict > >> Fix return for qxl_release_alloc > >> Handle correctly failures in qxl_alloc_relase_reserved > >> Remove format string errors > >> Move main reference counter to GEM object instead of TTM ones > >> Simplify cleaning qxl processing command > >> Propagate correctly errors from qxlhw_handle_to_bo > >> > >> qxl/qxl_cmd.c | 11 ++++++----- > >> qxl/qxl_display.c | 2 +- > >> qxl/qxl_drv.h | 2 +- > >> qxl/qxl_gem.c | 10 ++++++++-- > >> qxl/qxl_ioctl.c | 46 +++++++++++++++++----------------------------- > >> qxl/qxl_object.c | 11 ++++------- > >> qxl/qxl_release.c | 13 +++++++++---- > >> 7 files changed, 46 insertions(+), 49 deletions(-) > > > > The strip level on these patches is rather odd. Normally one would > > see a strip level of 1 at the top of the kernel dir. E.g. > > > > drivers/gpu/drm/qxl/qxl_gem.c > > > > in the diffstat, etc. > > (Sorry for the double reply.) > > Also, are any of these commits something that should be queued for > stable kernel releases? There are a handful that look like they > should be to me. > > josh > Hi, no problem for double reply. I was using a different repository with only QXL driver. I tested and all patches apply and compile perfectly even with Linus master branch. About which patches should be applied surely (attempting to put a priority) - "Move main reference counter to GEM object instead of TTM ones" this can causes memory corruption even not wanting to; - "Avoid double free on error" this can be cause leaks in kernel if user space wants, mitigated by the fact that usually DRM inodes are owned by root; - "Handle all errors in qxl_surface_evict" could cause corruption too, not really probable but taking into account that Xorg implementation use a lot signals is not so impossible; - "Handle correctly failures in qxl_alloc_relase_reserved", "Do not leak memory if qxl_release_list_add fails" just cause leaks on situation where memory is already REALLY low, can be omitted; - "Fix print statement not using uninitialized variable", "Remove format string errors" should just print garbage and debugging is disabled by default, not necessary. Frediano