public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] avr32: fix compiler warning
@ 2013-09-25 19:50 Gabor Juhos
  2013-09-26  6:18 ` Hans-Christian Egtvedt
  0 siblings, 1 reply; 3+ messages in thread
From: Gabor Juhos @ 2013-09-25 19:50 UTC (permalink / raw)
  To: Hans-Christian Egtvedt; +Cc: Haavard Skinnemoen, linux-kernel, Gabor Juhos

The patch fixes the following compiler warning:
    CC      arch/avr32/kernel/process.o
  arch/avr32/kernel/process.c: In function 'copy_thread':
  arch/avr32/kernel/process.c:292: warning: assignment makes integer \
  from pointer without a cast

Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
---
Note: the patch is against v3.12-rc2.
---
 arch/avr32/kernel/process.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/avr32/kernel/process.c b/arch/avr32/kernel/process.c
index c273100..42a53e74 100644
--- a/arch/avr32/kernel/process.c
+++ b/arch/avr32/kernel/process.c
@@ -289,7 +289,7 @@ int copy_thread(unsigned long clone_flags, unsigned long usp,
 		memset(childregs, 0, sizeof(struct pt_regs));
 		p->thread.cpu_context.r0 = arg;
 		p->thread.cpu_context.r1 = usp; /* fn */
-		p->thread.cpu_context.r2 = syscall_return;
+		p->thread.cpu_context.r2 = (unsigned long)syscall_return;
 		p->thread.cpu_context.pc = (unsigned long)ret_from_kernel_thread;
 		childregs->sr = MODE_SUPERVISOR;
 	} else {
-- 
1.7.10

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] avr32: fix compiler warning
  2013-09-25 19:50 [PATCH] avr32: fix compiler warning Gabor Juhos
@ 2013-09-26  6:18 ` Hans-Christian Egtvedt
  2013-09-26 18:23   ` Gabor Juhos
  0 siblings, 1 reply; 3+ messages in thread
From: Hans-Christian Egtvedt @ 2013-09-26  6:18 UTC (permalink / raw)
  To: Gabor Juhos; +Cc: Haavard Skinnemoen, linux-kernel

Around Wed 25 Sep 2013 21:50:01 +0200 or thereabout, Gabor Juhos wrote:

Tuning subject to

avr32: cast syscall_return to silence compiler warning

> The patch fixes the following compiler warning:
>     CC      arch/avr32/kernel/process.o
>   arch/avr32/kernel/process.c: In function 'copy_thread':
>   arch/avr32/kernel/process.c:292: warning: assignment makes integer \
>   from pointer without a cast

Thank you for fixing.

> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>

Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>

> ---
> Note: the patch is against v3.12-rc2.

Added to my for-linus branch.

> ---
>  arch/avr32/kernel/process.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/avr32/kernel/process.c b/arch/avr32/kernel/process.c
> index c273100..42a53e74 100644
> --- a/arch/avr32/kernel/process.c
> +++ b/arch/avr32/kernel/process.c
> @@ -289,7 +289,7 @@ int copy_thread(unsigned long clone_flags, unsigned long usp,
>  		memset(childregs, 0, sizeof(struct pt_regs));
>  		p->thread.cpu_context.r0 = arg;
>  		p->thread.cpu_context.r1 = usp; /* fn */
> -		p->thread.cpu_context.r2 = syscall_return;
> +		p->thread.cpu_context.r2 = (unsigned long)syscall_return;
>  		p->thread.cpu_context.pc = (unsigned long)ret_from_kernel_thread;
>  		childregs->sr = MODE_SUPERVISOR;
>  	} else {
-- 
mvh
Hans-Christian Egtvedt

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] avr32: fix compiler warning
  2013-09-26  6:18 ` Hans-Christian Egtvedt
@ 2013-09-26 18:23   ` Gabor Juhos
  0 siblings, 0 replies; 3+ messages in thread
From: Gabor Juhos @ 2013-09-26 18:23 UTC (permalink / raw)
  To: Hans-Christian Egtvedt; +Cc: Haavard Skinnemoen, linux-kernel

2013.09.26. 8:18 keltezéssel, Hans-Christian Egtvedt írta:
> Around Wed 25 Sep 2013 21:50:01 +0200 or thereabout, Gabor Juhos wrote:
> 
> Tuning subject to
> 
> avr32: cast syscall_return to silence compiler warning

This is indeed better, thanks.

> 
>> The patch fixes the following compiler warning:
>>     CC      arch/avr32/kernel/process.o
>>   arch/avr32/kernel/process.c: In function 'copy_thread':
>>   arch/avr32/kernel/process.c:292: warning: assignment makes integer \
>>   from pointer without a cast
> 
> Thank you for fixing.
> 
>> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
> 
> Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> 
>> ---
>> Note: the patch is against v3.12-rc2.
> 
> Added to my for-linus branch.

Thanks you!

-Gabor

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-09-26 18:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-25 19:50 [PATCH] avr32: fix compiler warning Gabor Juhos
2013-09-26  6:18 ` Hans-Christian Egtvedt
2013-09-26 18:23   ` Gabor Juhos

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox