Re: [tip:x86/reboot] x86/reboot: Remove the duplicate C6100 entry in the reboot quirks list

Ingo Molnar
2013-09-27T05:51:57Z

* H. Peter Anvin <hpa@zytor.com> wrote:

> On 09/26/2013 01:59 PM, Davidlohr Bueso wrote:
> >> - },
> >> - { /* Some C6100 machines were shipped with vendor being 'Dell'. */
> >> - .callback = set_pci_reboot,
> >> - .ident = "Dell PowerEdge C6100",
> >> - .matches = {
> >> DMI_MATCH(DMI_SYS_VENDOR, "Dell"),
> >> DMI_MATCH(DMI_PRODUCT_NAME, "C6100"),
> >> },
> >
> > Hmm, I think we should be keeping the 'Dell Inc.' part instead of just
> > 'Dell' - at least the rest of the entries use the same string:
> >
>
> The point is that some of the machines just has "Dell" in their vendor
> string.

Yes, so if then the argument could be made that all the other entries
should probably be changed to 'Dell' as well.

This is yet another reminder that DMI matches are such a fragile method
...

Thanks,

Ingo