public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@redhat.com>, Michal Marek <mmarek@suse.cz>,
	uml-devel <user-mode-linux-devel@lists.sourceforge.net>,
	Jeff Dike <jdike@addtoit.com>
Subject: Re: [PATCH 1/2] arch/um: make it work with defconfig and x86_64
Date: Fri, 27 Sep 2013 07:41:33 +0200	[thread overview]
Message-ID: <52451A8D.4080509@nod.at> (raw)
In-Reply-To: <1380255287-5818-2-git-send-email-artagnon@gmail.com>

Am 27.09.2013 06:14, schrieb Ramkumar Ramachandra:
> arch/um/defconfig only lists one default configuration, and that applies
> only to the i386 architecture.  Replace it with two minimal
> configuration files generated using `make savedefconfig`:
> 
>   i386_defconfig and x86_64_defconfig
> 
> The build scripts now require two updates:
> 
> 1. um's Kconfig (arch/x86/um/Kconfig) should specify an ARCH_DEFCONFIG
>    section explicitly pointing to these scripts if the required
>    variables are set.  Take care to remove the DEFCONFIG_LIST section
>    defined in the included file arch/um/Kconfig.common.
> 
> 2. um's Makefile (arch/um/Makefile) should set KBUILD_DEFCONFIG properly
>    for the top-level Makefile to pick up.  Copy the logic in
>    arch/x86/Makefile to properly pick the defconfig file depending on
>    the actual architecture; except we're working with $SUBARCH here,
>    instead of $ARCH.
> 
> Now, you can do:
> 
>   $ ARCH=um make defconfig
>   $ ARCH=um make
> 
> and successfully build User-Mode Linux on an x86_64 box in default
> configuration.

I don't much like the commit message, but I will amend it myself.
I.e. defconfig worked always on x86_64, you have to specify SUBARCH=x86_64.
Your patch adds the handy feature that make defconfig will use the host arch
automatically.

Patch queued for 3.13-rc1.

Thanks,
//richard

  reply	other threads:[~2013-09-27  5:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-27  4:14 [PATCH 0/2] More plesant User-Mode Linux build Ramkumar Ramachandra
2013-09-27  4:14 ` [PATCH 1/2] arch/um: make it work with defconfig and x86_64 Ramkumar Ramachandra
2013-09-27  5:41   ` Richard Weinberger [this message]
2013-09-27  4:14 ` [PATCH 2/2] um/vdso: add .gitignore for a couple of targets Ramkumar Ramachandra
2013-09-27  5:41   ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52451A8D.4080509@nod.at \
    --to=richard@nod.at \
    --cc=artagnon@gmail.com \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mmarek@suse.cz \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox