From: Vladimir Davydov <vdavydov@parallels.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: <mingo@kernel.org>, <hpa@zytor.com>,
<linux-kernel@vger.kernel.org>, <pjt@google.com>,
<peterz@infradead.org>, <tglx@linutronix.de>, <lkp@01.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Huang Ying <ying.huang@intel.com>,
<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:sched/core] sched/balancing: Fix cfs_rq-> task_h_load calculation
Date: Mon, 30 Sep 2013 12:14:03 +0400 [thread overview]
Message-ID: <524932CB.6040904@parallels.com> (raw)
In-Reply-To: <20130929094714.GM24743@yliu-dev.sh.intel.com>
On 09/29/2013 01:47 PM, Yuanhan Liu wrote:
> On Fri, Sep 20, 2013 at 06:46:59AM -0700, tip-bot for Vladimir Davydov wrote:
>> Commit-ID: 7e3115ef5149fc502e3a2e80719dba54a8e7409d
>> Gitweb:http://git.kernel.org/tip/7e3115ef5149fc502e3a2e80719dba54a8e7409d
>> Author: Vladimir Davydov<vdavydov@parallels.com>
>> AuthorDate: Sat, 14 Sep 2013 19:39:46 +0400
>> Committer: Ingo Molnar<mingo@kernel.org>
>> CommitDate: Fri, 20 Sep 2013 11:59:39 +0200
>>
>> sched/balancing: Fix cfs_rq->task_h_load calculation
>>
>> Patch a003a2 (sched: Consider runnable load average in move_tasks())
>> sets all top-level cfs_rqs' h_load to rq->avg.load_avg_contrib, which is
>> always 0. This mistype leads to all tasks having weight 0 when load
>> balancing in a cpu-cgroup enabled setup. There obviously should be sum
>> of weights of all runnable tasks there instead. Fix it.
> Hi Vladimir,
>
> FYI, Here we found a 17% netperf regression by this patch. Here are some
> changed stats between this commit 7e3115ef5149fc502e3a2e80719dba54a8e7409d
> and it's parent(3029ede39373c368f402a76896600d85a4f7121b)
Hello,
Could you please report the following info:
1) the test machine cpu topology (i.e. output of
/sys/devices/system/cpu/cpu*/{thread_siblings_list,core_siblings_list})
2) kernel config you used during the test
3) the output of /sys/kernel/debug/sched_features (debugfs mounted).
4) netperf server/client options
5) did you place netserver into a separate cpu cgroup?
Thanks.
next prev parent reply other threads:[~2013-09-30 8:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-14 15:39 [PATCH] sched: Fix task_h_load calculation Vladimir Davydov
2013-09-14 18:52 ` Paul Turner
2013-09-20 13:46 ` [tip:sched/core] sched/balancing: Fix cfs_rq-> " tip-bot for Vladimir Davydov
2013-09-29 9:47 ` Yuanhan Liu
2013-09-30 8:14 ` Vladimir Davydov [this message]
2013-10-01 2:22 ` Yuanhan Liu
2013-10-01 2:32 ` Paul Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524932CB.6040904@parallels.com \
--to=vdavydov@parallels.com \
--cc=fengguang.wu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=lkp@01.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox