Re: [PATCH] extcon: arizona: Get pdata from arizona structure not device

[Chanwoo Choi <cw00.choi@samsung.com>]

On 10/01/2013 05:22 PM, Charles Keepax wrote:
> On Tue, Oct 01, 2013 at 08:04:09AM +0900, Chanwoo Choi wrote:
>> On 09/30/2013 06:52 PM, Charles Keepax wrote:
>>> On Mon, Sep 30, 2013 at 08:37:30AM +0900, Chanwoo Choi wrote:
>>>> No, extcon-arizona driver don't currently support DT to get platform data.
>>>> I cannot find some dt function to parse data from dts file.
>>>> You have to implement extcon-arizona driver by using DT binding style
>>>> to get platform data. I think this patch is not necessary.
>>>
>>> Currently the Arizona MFD driver reads the device tree
>>> information and populates the pdata structure, this happens in
>>> drivers/mfd/arizona-core.c. Then the various drivers just use the
>>> pdata as normal.
>>>
>>> Admittedly, at the moment we don't parse any data for the extcon
>>> driver but without this patch we will attempt to use a NULL
>>> pointer on device tree systems.
>>>
>>> I would also be happy to implement this as a NULL check on the
>>> pdata when we use it if that is preferable? But since we have the
>>> cached pdata seems we might as well use it.
>>>
>>
>> I find below pdata list for extcon-arizona driver.
>> But, drivers/mfd/arizona-core.c don't parse dt data for below pdata list
>> of extcon-arizona. Did you test this patch for extcon-arizona operation?
> 
> The extcon driver will function using its default settings if
> blank pdata is provided, so it has been tested with those
> settings. I am presently working on device tree bindings for the
> pdata for the extcon driver which I hope to send a new spin of
> upstream this week or next, so it has been tested against the
> first version of those patches as well.

OK,
I check arizona->pdata including the pdata field for extcon-arizona.

Applied it.

Thanks,
Chanwoo Choi