From: Stephen Warren <swarren@wwwdotorg.org>
To: Arto Merilainen <amerilainen@nvidia.com>
Cc: tbergstrom@nvidia.com, treding@nvidia.com,
dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, mkulkarni@nvidia.com
Subject: Re: [PATCHv3 4/4] gpu: host1x: Add runtime pm support for host1x
Date: Tue, 01 Oct 2013 12:17:14 -0600 [thread overview]
Message-ID: <524B11AA.30400@wwwdotorg.org> (raw)
In-Reply-To: <1380024325-18280-5-git-send-email-amerilainen@nvidia.com>
On 09/24/2013 06:05 AM, Arto Merilainen wrote:
> From: Mayuresh Kulkarni <mkulkarni@nvidia.com>
>
> This patch adds runtime pm support for host1x hardware unit. This
> allows host1x clock to be turned off when it is idle. If pm runtime
> is not configured, we enable host1x clock in device probe and disable
> it in remove.
> diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c
> +static int host1x_runtime_suspend(struct device *dev);
> +static int host1x_runtime_resume(struct device *dev);
You could avoid having these prototypes by simply putting the function
bodies earlier on in the file, somewhere before they're used. I don't
care much either way, but I've certainly seen some people care about
this and ask for them to be moved.
next prev parent reply other threads:[~2013-10-01 18:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 12:05 [PATCHv3 0/4] gpu: host1x: Add runtime pm support Arto Merilainen
2013-09-24 12:05 ` [PATCHv3 1/4] gpu: host1x: shuffle job APIs Arto Merilainen
2013-09-24 12:05 ` [PATCHv3 2/4] drm/tegra: Add runtime pm support for gr2d Arto Merilainen
2013-10-01 18:14 ` Stephen Warren
2013-10-02 5:40 ` Arto Merilainen
2013-09-24 12:05 ` [PATCHv3 3/4] drm/tegra: Add runtime pm support for dc Arto Merilainen
2013-09-24 12:05 ` [PATCHv3 4/4] gpu: host1x: Add runtime pm support for host1x Arto Merilainen
2013-10-01 18:17 ` Stephen Warren [this message]
2013-10-02 5:40 ` Arto Merilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524B11AA.30400@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=amerilainen@nvidia.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkulkarni@nvidia.com \
--cc=tbergstrom@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox