public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Chris Murphy <bugzilla@colorremedies.com>,
	Josh Boyer <jwboyer@fedoraproject.org>,
	khali@linux-fr.org, lm-sensors@lm-sensors.org,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: applesmc oops in 3.10/3.11
Date: Wed, 02 Oct 2013 06:30:09 -0700	[thread overview]
Message-ID: <524C1FE1.4050207@roeck-us.net> (raw)
In-Reply-To: <20131002095339.GA2716@polaris.bitmath.org>

On 10/02/2013 02:53 AM, Henrik Rydberg wrote:
>>> Patch added on top of 3.12.0-0.rc3.git0.1.fc20.x86_64 and built. But after ~dozen reboots, I'm not triggering the problem. The only items in dmesg with smc in it:
>>>
>>> [   13.799819] applesmc: key=261 fan=2 temp=14 index=14 acc=1 lux=2 kbd=1
>>> [   13.833402] input: applesmc as /devices/platform/applesmc.768/input/input10
>>>
>>
>> One thing I have seen in all logs is the earlier "send_byte fail" message, so
>> I think that is a pre-requisite.
>
> Not necessarily - it could be that the patch actually fixes the root
> cause. One possible scenario is that on recent SMCs, some of the
> commands produce more data than we actually read. This would
> eventually lead to both data corruption and overflow somwhere in the
> SMC internals.  If the original SMC error is interpreted as a read
> buffer overflow, then that problem should be fixed with this patch.
>

Good point.

But shouldn't we at least get the "flushed %d bytes" warning message in this case ?

Thanks,
Guenter


  reply	other threads:[~2013-10-02 13:30 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-25 19:06 applesmc oops in 3.10/3.11 Josh Boyer
2013-09-25 19:56 ` Guenter Roeck
2013-09-25 21:48   ` Henrik Rydberg
2013-09-25 22:08     ` Guenter Roeck
2013-09-26  6:34       ` Henrik Rydberg
2013-09-26 10:36         ` Guenter Roeck
2013-09-26 11:13           ` Henrik Rydberg
2013-09-26 10:53         ` Guenter Roeck
2013-09-26 11:11           ` Henrik Rydberg
2013-09-27 16:21         ` Josh Boyer
2013-09-27 17:12           ` Guenter Roeck
2013-09-27 17:41             ` Chris Murphy
2013-09-27 17:59               ` Guenter Roeck
2013-09-27 18:03                 ` Chris Murphy
2013-09-27 23:33                   ` Guenter Roeck
2013-10-01  1:57                     ` Chris Murphy
2013-10-01  3:37                       ` Guenter Roeck
2013-10-01 10:55                         ` Henrik Rydberg
2013-10-01 15:19                           ` Guenter Roeck
2013-10-01 15:33                             ` Chris Murphy
2013-10-01 16:24                               ` Guenter Roeck
2013-10-02  1:09                                 ` Chris Murphy
2013-10-02  3:51                                   ` Guenter Roeck
2013-10-02  3:55                                     ` Chris Murphy
2013-10-02  4:02                                       ` Guenter Roeck
2013-10-02  9:53                                     ` Henrik Rydberg
2013-10-02 13:30                                       ` Guenter Roeck [this message]
2013-10-02 16:34                                         ` Henrik Rydberg
2013-10-02 16:47                                           ` Guenter Roeck
2013-10-02 17:24                                             ` Henrik Rydberg
2013-10-02 18:02                                               ` Guenter Roeck
2013-10-02 18:33                                                 ` Chris Murphy
2013-10-02 20:59                                                   ` Guenter Roeck
2013-10-02 21:34                                                     ` Chris Murphy
2013-10-02 23:32                                                       ` Guenter Roeck
2013-10-07 23:42                                               ` Guenter Roeck
2013-10-07 23:46                                                 ` Chris Murphy
2013-10-08 15:48                                                   ` Guenter Roeck
2013-10-08 16:29                                                     ` Henrik Rydberg
2013-10-08 16:29                                                       ` Guenter Roeck
2013-10-09  8:29                                                         ` Henrik Rydberg
2013-10-09 16:52                                                           ` Guenter Roeck
2013-09-27 18:01           ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524C1FE1.4050207@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=bugzilla@colorremedies.com \
    --cc=jwboyer@fedoraproject.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=rydberg@euromail.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox