From: Roger Quadros <rogerq@ti.com>
To: Benoit Cousson <bcousson@baylibre.com>
Cc: <balbi@ti.com>, <tony@atomide.com>, <p.zabel@pengutronix.de>,
<broonie@kernel.org>, <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 05/10] ARM: dts: omap3-beagle: Use reset-gpios for hsusb2_reset
Date: Thu, 3 Oct 2013 16:58:36 +0300 [thread overview]
Message-ID: <524D780C.1090708@ti.com> (raw)
In-Reply-To: <524D74A5.7010604@baylibre.com>
Hi Benoit,
On 10/03/2013 04:44 PM, Benoit Cousson wrote:
> On 03/10/2013 14:05, Benoit Cousson wrote:
>> Hi Roger,
>>
>> Yes, I will. I've been waiting for these ones for so long :-)
>
> In fact it does not apply correctly on my for_3.13/dts branch :-(
>
> error: arch/arm/boot/dts/omap3-beagle.dts: patch does not apply
> Patch failed at 0004 ARM: dts: omap3-beagle: Make USB host pin naming consistent
>
> Could you rebase it?
Looks like it was already applied before. Could you please skip that and use the rest?
I've checked that the remaining patches apply fine on top of your for_3.13/dts
branch.
cheers,
-roger
>>
>> On 03/10/2013 12:34, Roger Quadros wrote:
>>> Hi Benoit,
>>>
>>> Could you please take the device tree related patches [5 to 10] in
>>> this series?
>>> Thanks.
>>>
>>> cheers,
>>> -roger
>>>
>>> On 09/24/2013 11:53 AM, Roger Quadros wrote:
>>>> We no longer need to model the RESET line as a regulator since
>>>> the USB phy-nop driver accepts "reset-gpios" property.
>>>>
>>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>>> ---
>>>> arch/arm/boot/dts/omap3-beagle.dts | 13 +------------
>>>> 1 files changed, 1 insertions(+), 12 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/omap3-beagle.dts
>>>> b/arch/arm/boot/dts/omap3-beagle.dts
>>>> index dfd8310..71bde47 100644
>>>> --- a/arch/arm/boot/dts/omap3-beagle.dts
>>>> +++ b/arch/arm/boot/dts/omap3-beagle.dts
>>>> @@ -44,17 +44,6 @@
>>>> };
>>>> };
>>>>
>>>> - /* HS USB Port 2 RESET */
>>>> - hsusb2_reset: hsusb2_reset_reg {
>>>> - compatible = "regulator-fixed";
>>>> - regulator-name = "hsusb2_reset";
>>>> - regulator-min-microvolt = <3300000>;
>>>> - regulator-max-microvolt = <3300000>;
>>>> - gpio = <&gpio5 19 0>; /* gpio_147 */
>>>> - startup-delay-us = <70000>;
>>>> - enable-active-high;
>>>> - };
>>>> -
>>>> /* HS USB Port 2 Power */
>>>> hsusb2_power: hsusb2_power_reg {
>>>> compatible = "regulator-fixed";
>>>> @@ -68,7 +57,7 @@
>>>> /* HS USB Host PHY on PORT 2 */
>>>> hsusb2_phy: hsusb2_phy {
>>>> compatible = "usb-nop-xceiv";
>>>> - reset-supply = <&hsusb2_reset>;
>>>> + reset-gpios = <&gpio5 19 GPIO_ACTIVE_LOW>; /* gpio_147 */
>>>> vcc-supply = <&hsusb2_power>;
>>>> };
>>>>
>>>>
>>>
>>
>
next prev parent reply other threads:[~2013-10-03 13:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 8:53 [PATCH v3 00/10] USB: phy: phy-nop: Manage RESET GPIO in the driver Roger Quadros
2013-09-24 8:53 ` [PATCH v3 01/10] usb: phy: generic: Add gpio_reset to platform data Roger Quadros
2013-09-24 8:53 ` [PATCH v3 02/10] usb: phy: generic: Don't use regulator framework for RESET line Roger Quadros
2013-09-24 8:53 ` [PATCH v3 03/10] ARM: OMAP2+: omap-usb-host: Get rid of platform_data from struct usbhs_phy_data Roger Quadros
2013-10-02 10:19 ` Roger Quadros
2013-10-03 4:03 ` Tony Lindgren
2013-09-24 8:53 ` [PATCH v3 04/10] ARM: OMAP2+: usb-host: Adapt to USB phy-nop RESET line changes Roger Quadros
2013-10-02 10:20 ` Roger Quadros
2013-10-03 4:03 ` Tony Lindgren
2013-09-24 8:53 ` [PATCH v3 05/10] ARM: dts: omap3-beagle: Use reset-gpios for hsusb2_reset Roger Quadros
2013-10-03 10:34 ` Roger Quadros
2013-10-03 12:05 ` Benoit Cousson
2013-10-03 13:44 ` Benoit Cousson
2013-10-03 13:58 ` Roger Quadros [this message]
2013-10-03 14:25 ` Benoit Cousson
2013-09-24 8:53 ` [PATCH v3 06/10] ARM: dts: omap4-panda: Use reset-gpios for hsusb1_reset Roger Quadros
2013-09-24 8:53 ` [PATCH v3 07/10] ARM: dts: omap5-uevm: Use reset-gpios for hsusb2/3_reset Roger Quadros
2013-09-24 8:53 ` [PATCH v3 08/10] ARM: dts: omap3-beagle: Make USB host pin naming consistent Roger Quadros
2013-09-24 8:53 ` [PATCH v3 09/10] ARM: dts: omap3-beagle-xm: Add USB Host support Roger Quadros
2013-11-19 21:05 ` Nishanth Menon
2013-11-20 10:32 ` Roger Quadros
2013-11-26 21:04 ` Tony Lindgren
2013-11-26 22:15 ` Nishanth Menon
2013-09-24 8:53 ` [PATCH v3 10/10] ARM: dts: omap3-beagle: Add USB OTG PHY details Roger Quadros
2013-10-03 10:32 ` [PATCH v3 00/10] USB: phy: phy-nop: Manage RESET GPIO in the driver Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524D780C.1090708@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox