From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>, broonie@kernel.org
Cc: swarren@nvidia.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com
Subject: Re: [PATCH] regulator: palmas: get regulators node from parent node only
Date: Fri, 04 Oct 2013 14:55:07 -0600 [thread overview]
Message-ID: <524F2B2B.9020303@wwwdotorg.org> (raw)
In-Reply-To: <1380809197-7759-1-git-send-email-ldewangan@nvidia.com>
On 10/03/2013 08:06 AM, Laxman Dewangan wrote:
> The device tree binding of Palmas regulator driver says as:
>
> palmas_pmis {
> compatible = "ti,palmas-pmic";
> ...
> regulators {
> ...
> }
> };
>
> In this "regulators" subnode is expected to be part of parent node, not
> the outside of parent node. Hence to get the regulator node, the correct
> call is of_get_child_by_name() rather than of_find_node_by_name() which
> actually searches the "regulators" node from the parent node to end of DTS
> file.
Reviewed-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2013-10-04 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 14:06 [PATCH] regulator: palmas: get regulators node from parent node only Laxman Dewangan
2013-10-04 20:55 ` Stephen Warren [this message]
2013-10-07 11:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524F2B2B.9020303@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=broonie@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox