* [PATCH] regulator: core: Always warn when using a dummy regulator
@ 2013-10-04 10:44 Mark Brown
2013-10-04 20:59 ` Stephen Warren
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2013-10-04 10:44 UTC (permalink / raw)
To: Liam Girdwood, Stephen Warren; +Cc: linux-kernel, linaro-kernel, Mark Brown
From: Mark Brown <broonie@linaro.org>
This helps people spot if they have missed a supply from a device tree or
equivalent data structure.
Suggested-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
---
drivers/regulator/core.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 6333080..13263d1 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1299,13 +1299,8 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
* even if it isn't hooked up and just provide a dummy.
*/
if (has_full_constraints && allow_dummy) {
- /*
- * Log the substitution if regulator configuration is
- * not complete to help development.
- */
- if (!has_full_constraints)
- pr_warn("%s supply %s not found, using dummy regulator\n",
- devname, id);
+ pr_warn("%s supply %s not found, using dummy regulator\n",
+ devname, id);
rdev = dummy_regulator_rdev;
goto found;
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: core: Always warn when using a dummy regulator
2013-10-04 10:44 [PATCH] regulator: core: Always warn when using a dummy regulator Mark Brown
@ 2013-10-04 20:59 ` Stephen Warren
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Warren @ 2013-10-04 20:59 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: linux-kernel, linaro-kernel, Mark Brown
On 10/04/2013 04:44 AM, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> This helps people spot if they have missed a supply from a device tree or
> equivalent data structure.
>
> Suggested-by: Stephen Warren <swarren@nvidia.com>
Oh, well I was going to ack it, but I guess there's no point since I
suggested it:-)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-04 20:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-04 10:44 [PATCH] regulator: core: Always warn when using a dummy regulator Mark Brown
2013-10-04 20:59 ` Stephen Warren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox