From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Philipp Stanner <pstanner@redhat.com>,
William Breathitt Gray <wbg@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] counter: intel-qep: Replace deprecated PCI functions
Date: Fri, 1 Nov 2024 15:12:48 +0200 [thread overview]
Message-ID: <524e3174-cfff-495c-ba0f-f02d78c2f0bc@linux.intel.com> (raw)
In-Reply-To: <20241028091312.17045-2-pstanner@redhat.com>
On 10/28/24 11:13 AM, Philipp Stanner wrote:
> pcim_iomap_regions() and pcim_iomap_table() have been deprecated in
> commit e354bb84a4c1 ("PCI: Deprecate pcim_iomap_table(),
> pcim_iomap_regions_request_all()").
>
> Replace these functions with pcim_iomap_region().
>
> Signed-off-by: Philipp Stanner <pstanner@redhat.com>
> ---
> drivers/counter/intel-qep.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/counter/intel-qep.c b/drivers/counter/intel-qep.c
> index af5942e66f7d..ee2bae27b728 100644
> --- a/drivers/counter/intel-qep.c
> +++ b/drivers/counter/intel-qep.c
> @@ -408,13 +408,9 @@ static int intel_qep_probe(struct pci_dev *pci, const struct pci_device_id *id)
>
> pci_set_master(pci);
>
> - ret = pcim_iomap_regions(pci, BIT(0), pci_name(pci));
> - if (ret)
> - return ret;
> -
> - regs = pcim_iomap_table(pci)[0];
> - if (!regs)
> - return -ENOMEM;
> + regs = pcim_iomap_region(pci, 0, pci_name(pci));
> + if (IS_ERR(regs))
> + return PTR_ERR(regs);
>
> qep->dev = dev;
> qep->regs = regs;
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
prev parent reply other threads:[~2024-11-01 13:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 9:13 [PATCH] counter: intel-qep: Replace deprecated PCI functions Philipp Stanner
2024-11-01 6:04 ` William Breathitt Gray
2024-11-01 13:12 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524e3174-cfff-495c-ba0f-f02d78c2f0bc@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pstanner@redhat.com \
--cc=wbg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox