From: Roland Dreier <rolandd@cisco.com>
To: gcoady@gmail.com
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci_ids: cleanup comments
Date: Wed, 19 Oct 2005 14:35:25 -0700 [thread overview]
Message-ID: <524q7di40y.fsf@cisco.com> (raw)
In-Reply-To: <4eedl1h86sarh1i5g42o7vi21i7v1ece2m@4ax.com> (Grant Coady's message of "Thu, 20 Oct 2005 07:27:41 +1000")
I don't think I like this. I prefer the format
#define PCI_DEVICE_ID_NEC_CBUS_1 0x0001 /* PCI-Cbus Bridge */
to taking two lines like
/* PCI-Cbus Bridge */
#define PCI_DEVICE_ID_NEC_CBUS_1 0x0001
If some script can't handle the first format then I think the script
should be fixed.
- R.
next prev parent reply other threads:[~2005-10-19 21:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-19 21:27 [PATCH] pci_ids: cleanup comments Grant Coady
2005-10-19 21:35 ` Roland Dreier [this message]
2005-10-19 21:45 ` Greg KH
2005-10-19 22:19 ` Grant Coady
2005-10-19 22:27 ` Greg KH
2005-10-19 23:55 ` Grant Coady
-- strict thread matches above, loose matches on Subject: below --
2005-10-19 5:37 Grant Coady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524q7di40y.fsf@cisco.com \
--to=rolandd@cisco.com \
--cc=gcoady@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox